Replay: some code motion & reuse ReplayCommittedState#4849
Merged
Conversation
coolreader18
approved these changes
Apr 21, 2026
Centril
force-pushed
the
centril/extract-replay-3
branch
from
8a60155 to
d8991ae
Compare
Centril
force-pushed
the
centril/extract-replay-3
branch
from
d8991ae to
129a4e8
Compare
bfops
added a commit
that referenced
this pull request
Apr 23, 2026
# Description of Changes Revert the following PRs that have caused some breakage: ``` a32cffa Finish refactoring out replay (#4850) d639be0 Replay: some code motion & reuse `ReplayCommittedState` (#4849) 78d6b6f Update NativeAOT-LLVM infrastructure to current ABI (#4515) d5c1738 Better module backtraces for panics and whatnot (#577) 6f23b19 Wait for database update to become durable (#4846) 81c9eab Add `spacetime lock/unlock` to prevent accidental database deletion (#4502) 809aebd Move field `replay_table_updated` to `ReplayCommittedState` (#4807) 21b58ef Update axum (#2713) b5cadff Extract replay stuff out of `CommittedState`, part 1 (#4804) ``` I also updated the Python smoketests for breakage introduced in #4502. Reverting that PR caused conflicts, so this fix is more straightforward. # API and ABI breaking changes Maybe kind of, but we haven't released any of these. # Expected complexity level and risk 1 # Testing Ask @bfops about testing --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
First two commits are code motion.
The second commit fixes a mistake I made in a previous PR that made us use potentially several
ReplayCommittedStates perdatastore.replay(..).More to come in terms of PRs; stay tuned.
API and ABI breaking changes
None
Expected complexity level and risk
3