Skip to content

feat: (CM64) Allow component model resources to be represented by i64 as well as i32. #2496

Merged
alexcrichton merged 9 commits intobytecodealliance:mainfrom
michael-weigelt:mwe/comp64
Apr 21, 2026
Merged

feat: (CM64) Allow component model resources to be represented by i64 as well as i32. #2496
alexcrichton merged 9 commits intobytecodealliance:mainfrom
michael-weigelt:mwe/comp64

Conversation

@michael-weigelt
Copy link
Copy Markdown
Contributor

@michael-weigelt michael-weigelt commented Apr 17, 2026

This is the first PR in a series to enable verification of 64bit component model modules. The effort is tracked here.

This PR extends the component model's resource rep immediate to allow i64 and gates this behind a feature flag CM64, which corresponds to the elephant emoji 🐘 in the spec PR.

Comment thread crates/wasmparser/src/validator/component.rs
Comment thread crates/wasmparser/src/validator/component.rs Outdated
@michael-weigelt michael-weigelt changed the title Allow resource rep i64 feat: (CM64) Allow component model resources to be represented by i64 as well as i32. Apr 20, 2026
@michael-weigelt michael-weigelt marked this pull request as ready for review April 21, 2026 09:32
@michael-weigelt michael-weigelt requested a review from a team as a code owner April 21, 2026 09:32
@michael-weigelt michael-weigelt requested review from alexcrichton and removed request for a team April 21, 2026 09:32
@michael-weigelt
Copy link
Copy Markdown
Contributor Author

Do we squash merge? I hope so, otherwise I'll be more cautious with my commits.

Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed yeah we do the squash & merge commit strategy so no need to fret too much about commit history

Comment thread tests/cli/component-model/resources.wast Outdated
Comment thread tests/cli/component-model/memory64.wast
Comment thread crates/wasmparser/src/validator/component.rs Outdated
@alexcrichton alexcrichton enabled auto-merge April 21, 2026 16:30
@alexcrichton alexcrichton added this pull request to the merge queue Apr 21, 2026
Merged via the queue into bytecodealliance:main with commit 3fd2bd7 Apr 21, 2026
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants