Add VirtualAuthenticator tests to Ruby examples#1536
Closed
tcannonfodder wants to merge 2 commits intoSeleniumHQ:trunkfrom
Closed
Add VirtualAuthenticator tests to Ruby examples#1536tcannonfodder wants to merge 2 commits intoSeleniumHQ:trunkfrom
tcannonfodder wants to merge 2 commits intoSeleniumHQ:trunkfrom
Conversation
* Adding these tests helps document how the Selenium library can be used with virtual authenticators
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
Member
|
@tcannonfodder can you merge trunk into your branch? Or make the PR editable so we can do that for you. |
Author
|
Done! |
Member
|
Please check the linter errors. It is easier if you let us update your branch because we are merging other PRs and yours will be out of date. |
Author
|
Hey there! I’m not seeing the option to do so on my end :/, based on these docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
|
Member
|
OK. Why don't you skip the failed test and leave a note on it? |
3 tasks
Author
Member
|
Thanks. I will close this one and follow up on the other one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Motivation and Context
Types of changes
Checklist