Skip to content

fix(java-restclient): Spring 7 wrong serializers setup#23588

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
alex-nt:bugfix/java.restclient.spring7.serialisation
Apr 21, 2026
Merged

fix(java-restclient): Spring 7 wrong serializers setup#23588
wing328 merged 1 commit intoOpenAPITools:masterfrom
alex-nt:bugfix/java.restclient.spring7.serialisation

Conversation

@alex-nt
Copy link
Copy Markdown
Contributor

@alex-nt alex-nt commented Apr 18, 2026

For spring-boot:4/spring:7 the appropriate way of adding the message converters in our context seems to be via addCustomConverter as those are always added.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes serialization in Spring Boot 4 RestClient clients by adding Jackson JSON/XML message converters via addCustomConverter instead of withJsonConverter/withXmlConverter. Ensures converters are always registered under Spring 7 / Boot 4, restoring correct request/response handling.

Written for commit 1c9e21b. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@alex-nt alex-nt changed the title Fix serialisation in spring-boot 4 for Java restclient fix(java-restclient): Spring 7 wrong serializers setup Apr 20, 2026
@wing328 wing328 merged commit e317a7a into OpenAPITools:master Apr 21, 2026
104 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants