Skip to content

Fix wrong import statements in dart-dio when using import-mappings#23571

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
FlagshipApps:feat/fix-dart-dio
Apr 23, 2026
Merged

Fix wrong import statements in dart-dio when using import-mappings#23571
wing328 merged 1 commit intoOpenAPITools:masterfrom
FlagshipApps:feat/fix-dart-dio

Conversation

@bw-flagship
Copy link
Copy Markdown
Contributor

@bw-flagship bw-flagship commented Apr 16, 2026

Fixes #23558

@jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes wrong imports in dart-dio when using --type-mappings with --import-mappings. Generated code now imports/exports the mapped package path and skips generating duplicate model files.

  • Bug Fixes
    • Use vendorExtensions.x-import-path for model imports/exports in the barrel file and serializers (built_value and json_serializable).
    • Detect models that are both type-mapped and import-mapped and do not generate their model files.
    • Add tests and a sample spec to verify custom paths are used in models, serializers, and the barrel file.

Written for commit 56a2062. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

continue;
}
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @OpenAPITools/generator-core-team

@bw-flagship
Copy link
Copy Markdown
Contributor Author

I believe the failing checks have nothing to do with the code changes:

503 Service Unavailable when fetching dependencies

Could we rerun @wing328 ?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 23, 2026

please ignore the circle ci failure as it's not related to this change.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 23, 2026

thanks for the fix

let's give it a try

@wing328 wing328 merged commit 388f031 into OpenAPITools:master Apr 23, 2026
13 of 15 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] (Dart-Dio) import-mappings are ignored in some import statements

2 participants