Skip to content

Update sponsor section formatting in README#23554

Merged
wing328 merged 4 commits intomasterfrom
wing328-patch-1
Apr 15, 2026
Merged

Update sponsor section formatting in README#23554
wing328 merged 4 commits intomasterfrom
wing328-patch-1

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Apr 15, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Cleaned up the sponsor sections in README with left‑aligned logos and consistent spacing across both sponsor lists.

  • Refactors
    • Applied <img align="left"> to all sponsor logos; standardized sizes (128x128 for bronze, 150 width for partners).
    • Added <br clear="left"> after both lists to clear floats and prevent overlap; kept original headings.

Written for commit 592cd29. Summary will update on new commits.

@wing328 wing328 marked this pull request as ready for review April 15, 2026 10:50
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="README.md">

<violation number="1" location="README.md:82">
P3: Using large fixed `<br>` blocks to clear floated logos is brittle and creates excessive whitespace; use a single float-clearing break/container instead of dozens of hard-coded line breaks.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread README.md Outdated
wing328 and others added 2 commits April 15, 2026 19:00
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
@wing328 wing328 merged commit a053922 into master Apr 15, 2026
15 checks passed
@wing328 wing328 deleted the wing328-patch-1 branch April 15, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant