Skip to content

[PowerShell] Correct comment syntax in array query parameters#23491

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ppritchard-peer:bugfix/issue-23489
Apr 8, 2026
Merged

[PowerShell] Correct comment syntax in array query parameters#23491
wing328 merged 1 commit intoOpenAPITools:masterfrom
ppritchard-peer:bugfix/issue-23489

Conversation

@ppritchard-peer
Copy link
Copy Markdown
Contributor

@ppritchard-peer ppritchard-peer commented Apr 8, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @wing328

fixes #23489


Summary by cubic

Fix invalid comment syntax in generated PowerShell clients for array query parameters by replacing '//' with '#'. Updates the PowerShell API client template and samples so generated scripts no longer throw syntax errors when building query strings (fixes #23489).

Written for commit 5246e25. Summary will update on new commits.

@ppritchard-peer ppritchard-peer marked this pull request as ready for review April 8, 2026 16:11
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@wing328 wing328 added this to the 7.22.0 milestone Apr 8, 2026
@wing328 wing328 merged commit 9f81af0 into OpenAPITools:master Apr 8, 2026
17 checks passed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 8, 2026

thanks for the PR which has been merged

ppritchard-peer added a commit to peersoftware/openapi-generator that referenced this pull request Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [PowerShell] Client has invalid comment syntax when using array query parameters

2 participants