build(deps): bump vite and @angular-devkit/build-angular in /samples/client/petstore/typescript-angular-v19#23461
Open
dependabot[bot] wants to merge 1 commit intomasterfrom
Conversation
Removes [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite). It's no longer used after updating ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Removes `vite` Updates `@angular-devkit/build-angular` from 19.0.2 to 21.2.6 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@19.0.2...v21.2.6) --- updated-dependencies: - dependency-name: vite dependency-version: dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-version: 21.2.6 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/typescript-angular-v19/package.json">
<violation number="1" location="samples/client/petstore/typescript-angular-v19/package.json:26">
P1: This upgrade introduces incompatible peer dependency requirements: `build-angular@21.2.6` requires Angular 21 and TypeScript >=5.9, but this sample is still on Angular 19 and TypeScript 5.6.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| }, | ||
| "devDependencies": { | ||
| "@angular-devkit/build-angular": "^19.0.2", | ||
| "@angular-devkit/build-angular": "^21.2.6", |
Contributor
There was a problem hiding this comment.
P1: This upgrade introduces incompatible peer dependency requirements: build-angular@21.2.6 requires Angular 21 and TypeScript >=5.9, but this sample is still on Angular 19 and TypeScript 5.6.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/typescript-angular-v19/package.json, line 26:
<comment>This upgrade introduces incompatible peer dependency requirements: `build-angular@21.2.6` requires Angular 21 and TypeScript >=5.9, but this sample is still on Angular 19 and TypeScript 5.6.</comment>
<file context>
@@ -23,7 +23,7 @@
},
"devDependencies": {
- "@angular-devkit/build-angular": "^19.0.2",
+ "@angular-devkit/build-angular": "^21.2.6",
"@angular/cli": "^21.1.0",
"@angular/compiler-cli": "^19.0.0",
</file context>
Suggested change
| "@angular-devkit/build-angular": "^21.2.6", | |
| "@angular-devkit/build-angular": "^19.0.2", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes vite. It's no longer used after updating ancestor dependency @angular-devkit/build-angular. These dependencies need to be updated together.
Removes
viteUpdates
@angular-devkit/build-angularfrom 19.0.2 to 21.2.6Release notes
Sourced from
@angular-devkit/build-angular's releases.... (truncated)
Changelog
Sourced from
@angular-devkit/build-angular's changelog.... (truncated)
Commits
9a2ee51release: cut the v21.2.6 release7bfe347refactor(@angular/build): extract headless configuration logic into helper fu...b7f4572fix(@angular/build): scope CHROME_BIN executable path to individual playwrigh...8f954e3build: safeguard terminal styling in devkit admin script57e956cbuild: update cross-repo angular dependencies750c461build: update pnpm to v10.33.0ea14f28fix(@angular/cli): fix sourceRoot resolution for MCP projects tool9136eb3fix(@angular/build): ensure transitive SCSS partial errors are tracked in wat...107d1a9fix(@angular/build): preserve error stack traces during prerendering8186faafix(@angular/build): ensure Vitest mock patching is executed only onceDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by cubic
Upgrade the TypeScript Angular v19 sample’s build tooling and remove the unused
viteto align with the current Angular CLI builder.@angular-devkit/build-angularfrom 19.0.2 to 21.2.6vite(no longer used after the builder upgrade)Written for commit bf7eeb9. Summary will update on new commits.