Skip to content

fixes #23454: Aligned exception handling of *AsyncWithHttpInfo with handling from *…#23455

Open
bkonetzny wants to merge 2 commits intoOpenAPITools:masterfrom
wirelane:fix-php-client-async-exception-handling
Open

fixes #23454: Aligned exception handling of *AsyncWithHttpInfo with handling from *…#23455
bkonetzny wants to merge 2 commits intoOpenAPITools:masterfrom
wirelane:fix-php-client-async-exception-handling

Conversation

@bkonetzny
Copy link
Copy Markdown

@bkonetzny bkonetzny commented Apr 7, 2026

Aligned the exception handling of the *AsyncWithHttpInfo with handling from *WithHttpInfo and only access getResponse if the exception is an instance of RequestException.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request @jebentier , @dkarlovi , @mandrean , @jfastnacht , @ybelenko , @renepardon

Summary by cubic

Aligns PHP client async exception handling with the sync *WithHttpInfo methods to avoid crashes and return consistent errors. Fixes #23454.

  • Bug Fixes
    • *AsyncWithHttpInfo now only reads getResponse() for RequestException; otherwise throws ApiException with code/message only.
    • Updated generator template and regenerated PHP samples to match sync behavior and prevent undefined method errors.

Written for commit 3ec86ab. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 13, 2026

thanks for the PR. please follow step 3 to update the samples

@bkonetzny
Copy link
Copy Markdown
Author

Thanks, I finally got the script running and update the samples. CircleCI seems to have failed, but that seems due to connection errors, not sure how to restart these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][PHP] operationAsyncWithHttpInfo incorrectly handles ConnectException (operationWithHttpInfo does this correct)

2 participants