feat(rust-server): refactor server module templates to avoid a monolithic run function.#23432
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Apr 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 15 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/rust-server/server-operation-handler.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/rust-server/server-operation-handler.mustache:223">
P2: Validation call is compiled only when `validate` feature is disabled, so validation logic never runs in validate builds.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address a potential issue with the rust-server generator for large APIs where the compilation hits an OOM error in small container images. By refactoring the server dispatches we remove the monolithic function and this means Cargo doesn't OOM.
Tested locally with my large API that generating with the new templates doesn't result in an OOM error.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Refactors the
rust-servergenerator to split the monolithicrun()into per-operation handler functions for servers and callbacks, reducing compile-time memory and preventingrustcOOMs on large APIs. Also guards against duplicate handler names whenoperationIds collide after snake_case normalization.Refactors
server-operation-handler.mustacheto generateasync fn handle_<operation>()per operation;server-operation.mustachenow dispatches to them.client-callbacks.mustache.duplicate-operation-id.yaml).Migration
hyperusage and behavior remain the same).Written for commit 3e8baaf. Summary will update on new commits.