Skip to content

fix(typescript-fetch): prevent HTML-escaping of pattern in validationAttributes#23420

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
gurkodil:typescript-fetch/remove-html-escaping-from-pattern
Apr 2, 2026
Merged

fix(typescript-fetch): prevent HTML-escaping of pattern in validationAttributes#23420
wing328 merged 1 commit intoOpenAPITools:masterfrom
gurkodil:typescript-fetch/remove-html-escaping-from-pattern

Conversation

@gurkodil
Copy link
Copy Markdown
Contributor

@gurkodil gurkodil commented Apr 1, 2026

Fixes issue where pattern in validationAttributes is HTML-escaped, resulting in invalid patterns like &.

cc:
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @dennisameling (2026/02)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes HTML-escaping of regex patterns in validationAttributes for the typescript-fetch generator. Generated pattern values now keep characters like & intact (e.g., '/^[a-z&]+$/').

  • Bug Fixes
    • Render pattern with {{{pattern}}} in validationAttributes.mustache to avoid HTML-escaping.
    • Add test to confirm raw pattern output (not &), and update test spec/samples with nickname using pattern '/^[a-z&]+$/'.

Written for commit 9dbde5b. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

@wing328 wing328 merged commit 5025997 into OpenAPITools:master Apr 2, 2026
16 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants