Skip to content

[php-nextgen] Remove invalid @implements ArrayAccess tag in models with parents#23418

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
JulianVennen:remove-implements
Apr 1, 2026
Merged

[php-nextgen] Remove invalid @implements ArrayAccess tag in models with parents#23418
wing328 merged 1 commit intoOpenAPITools:masterfrom
JulianVennen:remove-implements

Conversation

@JulianVennen
Copy link
Copy Markdown
Contributor

@JulianVennen JulianVennen commented Apr 1, 2026

This comment is currently invalid on classes with parent models as the import is missing. Since the parent already has this comment, I decided to just remove it here.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Removed the invalid @implements ArrayAccess docblock from generated PHP php-nextgen models that extend a parent. This prevents duplicate/incorrect annotations and fixes static analysis/IDE warnings.

  • Bug Fixes
    • Emit @implements ArrayAccess<string, mixed> only for models without a parent (guarded with {{^parentSchema}} in model.mustache).
    • Regenerated PHP samples to remove the tag from child classes (e.g., Cat, Dog, DataQuery).

Written for commit 753250b. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

@wing328 wing328 merged commit a336a4a into OpenAPITools:master Apr 1, 2026
24 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Apr 1, 2026
@JulianVennen JulianVennen deleted the remove-implements branch April 1, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants