Skip to content

[Php] Fix form data field names to use spec-defined baseName #23347

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
ksvirkou-hubspot:feature/phpFixNamingFormDataProcessor
Mar 26, 2026
Merged

[Php] Fix form data field names to use spec-defined baseName #23347
wing328 merged 3 commits intoOpenAPITools:masterfrom
ksvirkou-hubspot:feature/phpFixNamingFormDataProcessor

Conversation

@ksvirkou-hubspot
Copy link
Copy Markdown
Contributor

@ksvirkou-hubspot ksvirkou-hubspot commented Mar 25, 2026

In the form data preparation block, the key used when building the form data array was changed from {{paramName}} to {{baseName}}.

This fix ensures the form data field names sent in the request match the API's expected field names as defined in the OpenAPI spec, rather than using the PHP-normalized variable names.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Use spec-defined baseName for PHP form-data field names instead of PHP-normalized paramName. This makes multipart/form-data and form-encoded requests use the exact keys from the OpenAPI spec (e.g., dateTime, additionalMetadata).

  • Bug Fixes

    • In the PHP generator, form-data keys now use {{baseName}} during preparation.
    • Updated PHP samples and tests to reflect spec keys: dateTime, additionalMetadata, requiredFile, photoUrls.
  • Migration

    • Regenerate PHP clients to pick up the fix. If your server handled snake_case keys, ensure it accepts the spec-defined names.

Written for commit fec0278. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files


Since this is your first cubic review, here's how it works:

  • cubic automatically reviews your code and comments on bugs and improvements
  • Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
  • Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
  • Ask questions if you need clarification on any suggestion

@ksvirkou-hubspot
Copy link
Copy Markdown
Contributor Author

@wing328 wing328 merged commit 52b38b6 into OpenAPITools:master Mar 26, 2026
28 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Mar 26, 2026
@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 26, 2026

thanks for the PR which has been merged.

did you have a chance to try the php-nextgen client generator? would that meet your requirement?

@ksvirkou-hubspot
Copy link
Copy Markdown
Contributor Author

Thanks for merging.
I'll try to check php-nextgen within the next few hours.

@ksvirkou-hubspot
Copy link
Copy Markdown
Contributor Author

thanks for the PR which has been merged.

did you have a chance to try the php-nextgen client generator? would that meet your requirement?

#23360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants