[Php] Fix form data field names to use spec-defined baseName #23347
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Mar 26, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Contributor
Author
|
@jebentier , @dkarlovi , @mandrean , @jfastnacht , @ybelenko , @renepardon |
Member
|
thanks for the PR which has been merged. did you have a chance to try the php-nextgen client generator? would that meet your requirement? |
Contributor
Author
|
Thanks for merging. |
6 tasks
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the form data preparation block, the key used when building the form data array was changed from {{paramName}} to {{baseName}}.
This fix ensures the form data field names sent in the request match the API's expected field names as defined in the OpenAPI spec, rather than using the PHP-normalized variable names.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Use spec-defined baseName for PHP form-data field names instead of PHP-normalized paramName. This makes multipart/form-data and form-encoded requests use the exact keys from the OpenAPI spec (e.g., dateTime, additionalMetadata).
Bug Fixes
{{baseName}}during preparation.Migration
Written for commit fec0278. Summary will update on new commits.