Skip to content

Remove maven kotlin client tests (already tests in CI)#23346

Merged
wing328 merged 4 commits intomasterfrom
maventestupdate
Mar 25, 2026
Merged

Remove maven kotlin client tests (already tests in CI)#23346
wing328 merged 4 commits intomasterfrom
maventestupdate

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Mar 25, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Removes the Kotlin client Maven example and its CI step, modernizes the Spring example to Spring Boot 3 with Springdoc, and adds a dedicated JDK 17 workflow for Maven plugin tests.

  • Refactors
    • Deleted modules/openapi-generator-maven-plugin/examples/kotlin.xml and its compile step in .github/workflows/maven-plugin-tests.yaml.
    • Added .github/workflows/maven-plugin-tests-jdk17.yaml; moved the Spring example compile there and removed it from the default workflow.
    • Updated modules/openapi-generator-maven-plugin/examples/spring.xml to spring-boot-starter-parent 3.3.13, replaced Springfox with org.springdoc:springdoc-openapi-starter-webmvc-ui, and removed maven-compiler-plugin.

Written for commit 2fe34e0. Summary will update on new commits.

@wing328 wing328 marked this pull request as ready for review March 25, 2026 06:49
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@wing328 wing328 added this to the 7.22.0 milestone Mar 25, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".github/workflows/maven-plugin-tests-jdk17.yaml">

<violation number="1" location=".github/workflows/maven-plugin-tests-jdk17.yaml:32">
P2: Cache key prefix does not match restore-keys prefix, so fallback cache restoration won’t work for caches created by this job.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

~/.gradle
!~/.gradle/caches/*/plugin-resolution/
!~/.m2/repository/org/openapitools/
key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/pom.xml') }}
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Cache key prefix does not match restore-keys prefix, so fallback cache restoration won’t work for caches created by this job.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/maven-plugin-tests-jdk17.yaml, line 32:

<comment>Cache key prefix does not match restore-keys prefix, so fallback cache restoration won’t work for caches created by this job.</comment>

<file context>
@@ -0,0 +1,44 @@
+            ~/.gradle
+            !~/.gradle/caches/*/plugin-resolution/
+            !~/.m2/repository/org/openapitools/
+          key: ${{ runner.os }}-build-${{ env.cache-name }}-${{ hashFiles('**/pom.xml') }}
+          restore-keys: |
+            ${{ runner.os }}-test-maven-plugin-${{ env.cache-name }}-
</file context>
Fix with Cubic

@wing328 wing328 merged commit 2a4c1d6 into master Mar 25, 2026
16 of 17 checks passed
@wing328 wing328 deleted the maventestupdate branch March 25, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant