Skip to content

[csharp][generichost] Treat warnings as errors#23343

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
devhl-labs:devhl/warningsAsErrors
Mar 25, 2026
Merged

[csharp][generichost] Treat warnings as errors#23343
wing328 merged 2 commits intoOpenAPITools:masterfrom
devhl-labs:devhl/warningsAsErrors

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

@devhl-labs devhl-labs commented Mar 25, 2026

Make the samples more resilient to bad changes by treating warnings as errors.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 145 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@MisinformedDNA
Copy link
Copy Markdown
Contributor

Not everyone does this.

@devhl-labs
Copy link
Copy Markdown
Contributor Author

It only affects our samples.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 25, 2026

right as enabled via additional properties (options):

  treatWarningsAsErrors: true
  warningsNotAsErrors: CS0612

@wing328 wing328 merged commit 54d52e6 into OpenAPITools:master Mar 25, 2026
74 checks passed
@wing328 wing328 added this to the 7.22.0 milestone Mar 25, 2026
@devhl-labs devhl-labs deleted the devhl/warningsAsErrors branch March 25, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants