[csharp][generichost] Fix dateTimeOffset bug#23342
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 25, 2026
Merged
[csharp][generichost] Fix dateTimeOffset bug#23342wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
5 issues found across 378 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/models/NullableClass.md">
<violation number="1" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/models/NullableClass.md:10">
P2: Documentation lists optional value-type properties as non-nullable, but the generated model uses nullable types, so the docs are inaccurate and misleading about null handling.</violation>
</file>
<file name="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/PetApi.md">
<violation number="1" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/PetApi.md:286">
P2: Stream parameter type is rendered twice in API docs (`System.IO.Stream****System.IO.Stream`), producing malformed type text.</violation>
</file>
<file name="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md">
<violation number="1" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md:60">
P2: Docs list optional value-type parameters as non-nullable (`bool`, `decimal`, `int`, etc.) while also giving them `= null` defaults. This is not a valid C# signature and misleads users; optional value types should be nullable (`T?`) or use a non-null default.</violation>
<violation number="2" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md:451">
P2: Parameter type documentation is corrupted for binary stream (`System.IO.Stream` duplicated with broken markdown), reducing API doc correctness.</violation>
<violation number="3" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md:674">
P2: The documented C# method signature is invalid because it places a required parameter after optional parameters.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23338
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes incorrect date-time handling in the C#
generichostclient whenuseDateTimeOffsetis enabled. Date-time fields now useDateTimeOffsetfor deserialization, resolving #23338 and preventing timezone loss and casting errors.JsonConverter.mustacheto deserializedate-timeproperties asDateTimeOffsetwhenuseDateTimeOffsetis true.bin/configs/csharp-generichost-latest-dateTimeOffset.yamland generated sample atsamples/client/petstore/csharp/generichost/latest/UseDateTimeOffset..github/workflows/samples-dotnet10.yamlto build and test in CI.Written for commit 4f50766. Summary will update on new commits.