Skip to content

[csharp][generichost] Fix dateTimeOffset bug#23342

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
devhl-labs:devhl/23338-useDateTimeOffset-bug
Mar 25, 2026
Merged

[csharp][generichost] Fix dateTimeOffset bug#23342
wing328 merged 1 commit intoOpenAPITools:masterfrom
devhl-labs:devhl/23338-useDateTimeOffset-bug

Conversation

@devhl-labs
Copy link
Copy Markdown
Contributor

@devhl-labs devhl-labs commented Mar 25, 2026

Fixes #23338

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes incorrect date-time handling in the C# generichost client when useDateTimeOffset is enabled. Date-time fields now use DateTimeOffset for deserialization, resolving #23338 and preventing timezone loss and casting errors.

  • Bug Fixes
    • Updated JsonConverter.mustache to deserialize date-time properties as DateTimeOffset when useDateTimeOffset is true.
    • Added bin/configs/csharp-generichost-latest-dateTimeOffset.yaml and generated sample at samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset.
    • Included the new sample in .github/workflows/samples-dotnet10.yaml to build and test in CI.

Written for commit 4f50766. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5 issues found across 378 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/models/NullableClass.md">

<violation number="1" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/models/NullableClass.md:10">
P2: Documentation lists optional value-type properties as non-nullable, but the generated model uses nullable types, so the docs are inaccurate and misleading about null handling.</violation>
</file>

<file name="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/PetApi.md">

<violation number="1" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/PetApi.md:286">
P2: Stream parameter type is rendered twice in API docs (`System.IO.Stream****System.IO.Stream`), producing malformed type text.</violation>
</file>

<file name="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md">

<violation number="1" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md:60">
P2: Docs list optional value-type parameters as non-nullable (`bool`, `decimal`, `int`, etc.) while also giving them `= null` defaults. This is not a valid C# signature and misleads users; optional value types should be nullable (`T?`) or use a non-null default.</violation>

<violation number="2" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md:451">
P2: Parameter type documentation is corrupted for binary stream (`System.IO.Stream` duplicated with broken markdown), reducing API doc correctness.</violation>

<violation number="3" location="samples/client/petstore/csharp/generichost/latest/UseDateTimeOffset/docs/apis/FakeApi.md:674">
P2: The documented C# method signature is invalid because it places a required parameter after optional parameters.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@wing328 wing328 added this to the 7.22.0 milestone Mar 25, 2026
@wing328 wing328 merged commit 47d9912 into OpenAPITools:master Mar 25, 2026
34 checks passed
@devhl-labs devhl-labs deleted the devhl/23338-useDateTimeOffset-bug branch March 25, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][csharp][generichost] useDateTimeOffset loses the original wire offset during deserialization

2 participants