Skip to content

[php]: Fix documentation model header#23306

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
coffeemakr:feature/php-fix-md-model-header
Mar 21, 2026
Merged

[php]: Fix documentation model header#23306
wing328 merged 1 commit intoOpenAPITools:masterfrom
coffeemakr:feature/php-fix-md-model-header

Conversation

@coffeemakr
Copy link
Copy Markdown
Contributor

@coffeemakr coffeemakr commented Mar 21, 2026

Fix the MD model header

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

php members: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon


Summary by cubic

Fixes duplicate H1 headers in generated PHP model docs. Model pages now use a single "# {Classname}" header for correct Markdown rendering.

  • Bug Fixes
    • Removed the extra leading "#" in model_doc.mustache for php and php-nextgen to prevent "# # {Classname}" headers.
    • Regenerated PHP sample docs to reflect the corrected headers.

Written for commit a6475e8. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 185 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@wing328 wing328 merged commit 8e969d4 into OpenAPITools:master Mar 21, 2026
24 of 25 checks passed
@wing328 wing328 added this to the 7.21.0 milestone Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants