Skip to content

[php-*] Fix indention of PHP documentation#23305

Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom
coffeemakr:feature/php-fix-indention
Mar 21, 2026
Merged

[php-*] Fix indention of PHP documentation#23305
wing328 merged 4 commits intoOpenAPITools:masterfrom
coffeemakr:feature/php-fix-indention

Conversation

@coffeemakr
Copy link
Copy Markdown
Contributor

@coffeemakr coffeemakr commented Mar 21, 2026

Adjust the indention in the php comments.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fix PHPDoc indentation in generated PHP code across php-nextgen, php-symfony, and legacy php templates. This cleans up docblocks, aligns with PHPDoc/PSR-12 style, and avoids tooling warnings without changing runtime behavior.

  • Bug Fixes
    • Aligned leading asterisks and tags in docblocks (methods, enums, models, Symfony serializer annotations); added missing docblock starts where needed.
    • Regenerated PHP samples to reflect the formatting updates.

Written for commit 65fe0e9. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 182 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

@coffeemakr
Copy link
Copy Markdown
Contributor Author

@wing328 wing328 added this to the 7.21.0 milestone Mar 21, 2026
@wing328 wing328 merged commit 95a1f2f into OpenAPITools:master Mar 21, 2026
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants