Add scalafmt (plugin) to scala-akka client generator#23299
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="website/package.json">
<violation number="1" location="website/package.json:15">
P1: Upgrading to Docusaurus v3 without also upgrading React/ReactDOM and prism-react-renderer introduces dependency incompatibilities that can break install/build.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| "@docusaurus/plugin-google-analytics": "^2.3.1", | ||
| "@docusaurus/preset-classic": "^2.3.1", | ||
| "@docusaurus/utils": "^2.3.1", | ||
| "@docusaurus/core": "^3.9.2", |
Contributor
There was a problem hiding this comment.
P1: Upgrading to Docusaurus v3 without also upgrading React/ReactDOM and prism-react-renderer introduces dependency incompatibilities that can break install/build.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At website/package.json, line 15:
<comment>Upgrading to Docusaurus v3 without also upgrading React/ReactDOM and prism-react-renderer introduces dependency incompatibilities that can break install/build.</comment>
<file context>
@@ -12,10 +12,10 @@
- "@docusaurus/plugin-google-analytics": "^2.3.1",
- "@docusaurus/preset-classic": "^2.3.1",
- "@docusaurus/utils": "^2.3.1",
+ "@docusaurus/core": "^3.9.2",
+ "@docusaurus/plugin-google-analytics": "^3.9.2",
+ "@docusaurus/preset-classic": "^3.9.2",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on #23296 with updated tests
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds Scalafmt support to the Scala Akka client generator so generated projects have consistent, auto-formatting out of the box. Also updates website dependencies to
@docusaurus/*v3.9.2.New Features
project/plugins.sbtwithsbt-scalafmt2.5.6 and a.scalafmt.conf(Scala 2.13 dialect, opinionated rules).Dependencies
@docusaurus/core,@docusaurus/plugin-google-analytics,@docusaurus/preset-classic, and@docusaurus/utilsto^3.9.2; refreshedyarn.lock.Written for commit 7b8a829. Summary will update on new commits.