Skip to content

Add scalafmt (plugin) to scala-akka client generator#23299

Merged
wing328 merged 2 commits intomasterfrom
Desel72-add-scalafmt-scala-akka-client
Mar 20, 2026
Merged

Add scalafmt (plugin) to scala-akka client generator#23299
wing328 merged 2 commits intomasterfrom
Desel72-add-scalafmt-scala-akka-client

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Mar 20, 2026

based on #23296 with updated tests

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds Scalafmt support to the Scala Akka client generator so generated projects have consistent, auto-formatting out of the box. Also updates website dependencies to @docusaurus/* v3.9.2.

  • New Features

    • Generator now emits project/plugins.sbt with sbt-scalafmt 2.5.6 and a .scalafmt.conf (Scala 2.13 dialect, opinionated rules).
    • Samples updated to include these files; tests adjusted to expect 18 generated files.
  • Dependencies

    • Bumped @docusaurus/core, @docusaurus/plugin-google-analytics, @docusaurus/preset-classic, and @docusaurus/utils to ^3.9.2; refreshed yarn.lock.

Written for commit 7b8a829. Summary will update on new commits.

@wing328 wing328 changed the title Desel72 add scalafmt scala akka client Add scalafmt (plugin) to scala-akka client generator Mar 20, 2026
@wing328 wing328 added this to the 7.21.0 milestone Mar 20, 2026
@wing328 wing328 marked this pull request as ready for review March 20, 2026 04:19
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="website/package.json">

<violation number="1" location="website/package.json:15">
P1: Upgrading to Docusaurus v3 without also upgrading React/ReactDOM and prism-react-renderer introduces dependency incompatibilities that can break install/build.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread website/package.json
"@docusaurus/plugin-google-analytics": "^2.3.1",
"@docusaurus/preset-classic": "^2.3.1",
"@docusaurus/utils": "^2.3.1",
"@docusaurus/core": "^3.9.2",
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Upgrading to Docusaurus v3 without also upgrading React/ReactDOM and prism-react-renderer introduces dependency incompatibilities that can break install/build.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At website/package.json, line 15:

<comment>Upgrading to Docusaurus v3 without also upgrading React/ReactDOM and prism-react-renderer introduces dependency incompatibilities that can break install/build.</comment>

<file context>
@@ -12,10 +12,10 @@
-    "@docusaurus/plugin-google-analytics": "^2.3.1",
-    "@docusaurus/preset-classic": "^2.3.1",
-    "@docusaurus/utils": "^2.3.1",
+    "@docusaurus/core": "^3.9.2",
+    "@docusaurus/plugin-google-analytics": "^3.9.2",
+    "@docusaurus/preset-classic": "^3.9.2",
</file context>
Fix with Cubic

@wing328 wing328 merged commit 2893023 into master Mar 20, 2026
32 checks passed
@wing328 wing328 deleted the Desel72-add-scalafmt-scala-akka-client branch March 20, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants