fix(typescript-axios): add trailing commas to as const enums#23275
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Mar 17, 2026
Merged
Conversation
Keep enum object diffs smaller when values are appended.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
|
thanks for the PR cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @dennisameling (2026/02) |
scarf005
added a commit
to scarf005/openapi-generator
that referenced
this pull request
Mar 17, 2026
…23275) Keep enum object diffs smaller across Angular, Fetch, and NestJS server generators.
scarf005
added a commit
to scarf005/openapi-generator
that referenced
this pull request
Mar 24, 2026
…23275) Keep enum object diffs smaller across Angular, Fetch, and NestJS server generators.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
masterKeep
as constenum object diffs smaller when values are appended../mvnw -pl modules/openapi-generator -am -Dtest=TypeScriptAxiosClientCodegenTest -Dsurefire.failIfNoSpecifiedTests=false test./bin/generate-samples.sh ./bin/configs/typescript-axios*.yamlSummary by cubic
Add trailing commas to generated
as constenum objects intypescript-axiosto keep diffs small when new values are appended. This updates the templates and locks the behavior with a test.as constenums by updatingapiInner.mustache,modelGeneric.mustache, andmodelObjectEnum.mustache.typescript-axiossamples.Written for commit 05d9449. Summary will update on new commits.