Skip to content

[C#] Fix invalid implicit casts #23192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wing328 merged 1 commit into from
Mar 10, 2026
Merged

[C#] Fix invalid implicit casts #23192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...s/openapi-generator/src/main/resources/csharp/libraries/generichost/modelGeneric.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@
{{#deprecated}}
[Obsolete]
{{/deprecated}}
public {{#isNew}}new {{/isNew}}{{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{name}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{name}}Option; } {{^isReadOnly}}set { this.{{name}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}
public {{#isNew}}new {{/isNew}}{{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{name}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{name}}Option.Value; } {{^isReadOnly}}set { this.{{name}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}

{{/isEnum}}
{{/isDiscriminator}}
Expand All @@ -157,7 +157,7 @@
{{#deprecated}}
[Obsolete]
{{/deprecated}}
public {{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{#lambda.titlecase}}{{baseType}}{{/lambda.titlecase}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{#lambda.titlecase}}{{name}}{{/lambda.titlecase}}Option; } {{^isReadOnly}}set { this.{{#lambda.titlecase}}{{name}}{{/lambda.titlecase}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}
public {{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{#lambda.titlecase}}{{baseType}}{{/lambda.titlecase}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{#lambda.titlecase}}{{name}}{{/lambda.titlecase}}Option.Value; } {{^isReadOnly}}set { this.{{#lambda.titlecase}}{{name}}{{/lambda.titlecase}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}

{{/vendorExtensions.x-duplicated-data-type}}
{{/composedSchemas.anyOf}}
Expand Down Expand Up @@ -215,7 +215,7 @@
{{#deprecated}}
[Obsolete]
{{/deprecated}}
public new {{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{name}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{name}}Option } {{^isReadOnly}}set { this.{{name}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}
public new {{{datatypeWithEnum}}}{{#lambda.first}}{{#isNullable}}{{>NullConditionalProperty}} {{/isNullable}}{{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}}{{/lambda.first}} {{name}} {{#required}}{ get; {{^isReadOnly}}set; {{/isReadOnly}}}{{/required}}{{^required}}{ get { return this.{{name}}Option.Value; } {{^isReadOnly}}set { this.{{name}}Option = new{{^net70OrLater}} Option<{{{datatypeWithEnum}}}{{>NullConditionalProperty}}>{{/net70OrLater}}(value); } {{/isReadOnly}}}{{/required}}

{{/isNew}}
{{/isInherited}}
Expand Down
4 changes: 2 additions & 2 deletions ...sharp/generichost/latest/InlineEnumAnyOf/src/Org.OpenAPITools/Model/IconsSizeParameter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ internal IconsSizeParameter(Option<IconsSizeParameterAnyOf?> iconsSizeParameterA
/// <summary>
/// Gets or Sets IconsSizeParameterAnyOf
/// </summary>
public IconsSizeParameterAnyOf? IconsSizeParameterAnyOf { get { return this.IconsSizeParameterAnyOfOption; } set { this.IconsSizeParameterAnyOfOption = new(value); } }
public IconsSizeParameterAnyOf? IconsSizeParameterAnyOf { get { return this.IconsSizeParameterAnyOfOption.Value; } set { this.IconsSizeParameterAnyOfOption = new(value); } }

/// <summary>
/// Used to track the state of Int
Expand All @@ -66,7 +66,7 @@ internal IconsSizeParameter(Option<IconsSizeParameterAnyOf?> iconsSizeParameterA
/// <summary>
/// Gets or Sets Int
/// </summary>
public int? Int { get { return this.IntOption; } set { this.IntOption = new(value); } }
public int? Int { get { return this.IntOption.Value; } set { this.IntOption = new(value); } }

/// <summary>
/// Returns the string presentation of the object
Expand Down
4 changes: 2 additions & 2 deletions samples/client/petstore/csharp/generichost/net10/AnyOf/src/Org.OpenAPITools/Model/Fruit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public Fruit(Option<Apple?> apple, Option<Banana?> banana, Option<string?> color
/// <summary>
/// Gets or Sets Apple
/// </summary>
public Apple? Apple { get { return this.AppleOption; } set { this.AppleOption = new(value); } }
public Apple? Apple { get { return this.AppleOption.Value; } set { this.AppleOption = new(value); } }

/// <summary>
/// Used to track the state of Banana
Expand All @@ -69,7 +69,7 @@ public Fruit(Option<Apple?> apple, Option<Banana?> banana, Option<string?> color
/// <summary>
/// Gets or Sets Banana
/// </summary>
public Banana? Banana { get { return this.BananaOption; } set { this.BananaOption = new(value); } }
public Banana? Banana { get { return this.BananaOption.Value; } set { this.BananaOption = new(value); } }

/// <summary>
/// Used to track the state of Color
Expand Down
4 changes: 2 additions & 2 deletions ...ient/petstore/csharp/generichost/net10/AnyOfNoCompare/src/Org.OpenAPITools/Model/Fruit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public Fruit(Option<Apple?> apple, Option<Banana?> banana, Option<string?> color
/// <summary>
/// Gets or Sets Apple
/// </summary>
public Apple? Apple { get { return this.AppleOption; } set { this.AppleOption = new(value); } }
public Apple? Apple { get { return this.AppleOption.Value; } set { this.AppleOption = new(value); } }

/// <summary>
/// Used to track the state of Banana
Expand All @@ -68,7 +68,7 @@ public Fruit(Option<Apple?> apple, Option<Banana?> banana, Option<string?> color
/// <summary>
/// Gets or Sets Banana
/// </summary>
public Banana? Banana { get { return this.BananaOption; } set { this.BananaOption = new(value); } }
public Banana? Banana { get { return this.BananaOption.Value; } set { this.BananaOption = new(value); } }

/// <summary>
/// Used to track the state of Color
Expand Down
2 changes: 1 addition & 1 deletion ...ent/petstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Model/EnumArrays.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public EnumArrays(Option<List<EnumArraysArrayEnumInner>> arrayEnum = default, Op
/// Gets or Sets JustSymbol
/// </summary>
[JsonPropertyName("just_symbol")]
public EnumArraysJustSymbol? JustSymbol { get { return this.JustSymbolOption; } set { this.JustSymbolOption = new(value); } }
public EnumArraysJustSymbol? JustSymbol { get { return this.JustSymbolOption.Value; } set { this.JustSymbolOption = new(value); } }

/// <summary>
/// Used to track the state of ArrayEnum
Expand Down
16 changes: 8 additions & 8 deletions ...lient/petstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Model/EnumTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets EnumInteger
/// </summary>
[JsonPropertyName("enum_integer")]
public EnumTestEnumInteger? EnumInteger { get { return this.EnumIntegerOption; } set { this.EnumIntegerOption = new(value); } }
public EnumTestEnumInteger? EnumInteger { get { return this.EnumIntegerOption.Value; } set { this.EnumIntegerOption = new(value); } }

/// <summary>
/// Used to track the state of EnumIntegerOnly
Expand All @@ -88,7 +88,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets EnumIntegerOnly
/// </summary>
[JsonPropertyName("enum_integer_only")]
public EnumTestEnumIntegerOnly? EnumIntegerOnly { get { return this.EnumIntegerOnlyOption; } set { this.EnumIntegerOnlyOption = new(value); } }
public EnumTestEnumIntegerOnly? EnumIntegerOnly { get { return this.EnumIntegerOnlyOption.Value; } set { this.EnumIntegerOnlyOption = new(value); } }

/// <summary>
/// Used to track the state of EnumNumber
Expand All @@ -101,7 +101,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets EnumNumber
/// </summary>
[JsonPropertyName("enum_number")]
public TestEnumParametersEnumQueryDoubleParameter? EnumNumber { get { return this.EnumNumberOption; } set { this.EnumNumberOption = new(value); } }
public TestEnumParametersEnumQueryDoubleParameter? EnumNumber { get { return this.EnumNumberOption.Value; } set { this.EnumNumberOption = new(value); } }

/// <summary>
/// Used to track the state of EnumString
Expand All @@ -114,7 +114,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets EnumString
/// </summary>
[JsonPropertyName("enum_string")]
public EnumTestEnumString? EnumString { get { return this.EnumStringOption; } set { this.EnumStringOption = new(value); } }
public EnumTestEnumString? EnumString { get { return this.EnumStringOption.Value; } set { this.EnumStringOption = new(value); } }

/// <summary>
/// Used to track the state of OuterEnum
Expand All @@ -127,7 +127,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets OuterEnum
/// </summary>
[JsonPropertyName("outerEnum")]
public OuterEnum? OuterEnum { get { return this.OuterEnumOption; } set { this.OuterEnumOption = new(value); } }
public OuterEnum? OuterEnum { get { return this.OuterEnumOption.Value; } set { this.OuterEnumOption = new(value); } }

/// <summary>
/// Used to track the state of OuterEnumDefaultValue
Expand All @@ -140,7 +140,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets OuterEnumDefaultValue
/// </summary>
[JsonPropertyName("outerEnumDefaultValue")]
public OuterEnumDefaultValue? OuterEnumDefaultValue { get { return this.OuterEnumDefaultValueOption; } set { this.OuterEnumDefaultValueOption = new(value); } }
public OuterEnumDefaultValue? OuterEnumDefaultValue { get { return this.OuterEnumDefaultValueOption.Value; } set { this.OuterEnumDefaultValueOption = new(value); } }

/// <summary>
/// Used to track the state of OuterEnumInteger
Expand All @@ -153,7 +153,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets OuterEnumInteger
/// </summary>
[JsonPropertyName("outerEnumInteger")]
public OuterEnumInteger? OuterEnumInteger { get { return this.OuterEnumIntegerOption; } set { this.OuterEnumIntegerOption = new(value); } }
public OuterEnumInteger? OuterEnumInteger { get { return this.OuterEnumIntegerOption.Value; } set { this.OuterEnumIntegerOption = new(value); } }

/// <summary>
/// Used to track the state of OuterEnumIntegerDefaultValue
Expand All @@ -166,7 +166,7 @@ public EnumTest(EnumTestEnumString enumStringRequired, Option<EnumTestEnumIntege
/// Gets or Sets OuterEnumIntegerDefaultValue
/// </summary>
[JsonPropertyName("outerEnumIntegerDefaultValue")]
public OuterEnumIntegerDefaultValue? OuterEnumIntegerDefaultValue { get { return this.OuterEnumIntegerDefaultValueOption; } set { this.OuterEnumIntegerDefaultValueOption = new(value); } }
public OuterEnumIntegerDefaultValue? OuterEnumIntegerDefaultValue { get { return this.OuterEnumIntegerDefaultValueOption.Value; } set { this.OuterEnumIntegerDefaultValueOption = new(value); } }

/// <summary>
/// Gets or Sets additional properties
Expand Down
4 changes: 2 additions & 2 deletions ...client/petstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Model/GmFruit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public GmFruit(Option<Apple> apple, Option<Banana> banana, Option<string> color
/// <summary>
/// Gets or Sets Apple
/// </summary>
public Apple Apple { get { return this.AppleOption; } set { this.AppleOption = new(value); } }
public Apple Apple { get { return this.AppleOption.Value; } set { this.AppleOption = new(value); } }

/// <summary>
/// Used to track the state of Banana
Expand All @@ -67,7 +67,7 @@ public GmFruit(Option<Apple> apple, Option<Banana> banana, Option<string> color
/// <summary>
/// Gets or Sets Banana
/// </summary>
public Banana Banana { get { return this.BananaOption; } set { this.BananaOption = new(value); } }
public Banana Banana { get { return this.BananaOption.Value; } set { this.BananaOption = new(value); } }

/// <summary>
/// Used to track the state of Color
Expand Down
10 changes: 5 additions & 5 deletions ...store/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Model/MixedAnyOfContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public MixedAnyOfContent(Option<string> @string, Option<bool?> @bool, Option<int
/// <summary>
/// Gets or Sets String
/// </summary>
public string String { get { return this.StringOption; } set { this.StringOption = new(value); } }
public string String { get { return this.StringOption.Value; } set { this.StringOption = new(value); } }

/// <summary>
/// Used to track the state of Bool
Expand All @@ -71,7 +71,7 @@ public MixedAnyOfContent(Option<string> @string, Option<bool?> @bool, Option<int
/// <summary>
/// Gets or Sets Bool
/// </summary>
public bool? Bool { get { return this.BoolOption; } set { this.BoolOption = new(value); } }
public bool? Bool { get { return this.BoolOption.Value; } set { this.BoolOption = new(value); } }

/// <summary>
/// Used to track the state of Int
Expand All @@ -83,7 +83,7 @@ public MixedAnyOfContent(Option<string> @string, Option<bool?> @bool, Option<int
/// <summary>
/// Gets or Sets Int
/// </summary>
public int? Int { get { return this.IntOption; } set { this.IntOption = new(value); } }
public int? Int { get { return this.IntOption.Value; } set { this.IntOption = new(value); } }

/// <summary>
/// Used to track the state of Decimal
Expand All @@ -95,7 +95,7 @@ public MixedAnyOfContent(Option<string> @string, Option<bool?> @bool, Option<int
/// <summary>
/// Gets or Sets Decimal
/// </summary>
public decimal? Decimal { get { return this.DecimalOption; } set { this.DecimalOption = new(value); } }
public decimal? Decimal { get { return this.DecimalOption.Value; } set { this.DecimalOption = new(value); } }

/// <summary>
/// Used to track the state of MixedSubId
Expand All @@ -107,7 +107,7 @@ public MixedAnyOfContent(Option<string> @string, Option<bool?> @bool, Option<int
/// <summary>
/// Gets or Sets MixedSubId
/// </summary>
public MixedSubId MixedSubId { get { return this.MixedSubIdOption; } set { this.MixedSubIdOption = new(value); } }
public MixedSubId MixedSubId { get { return this.MixedSubIdOption.Value; } set { this.MixedSubIdOption = new(value); } }

/// <summary>
/// Gets or Sets additional properties
Expand Down
2 changes: 1 addition & 1 deletion ...s/client/petstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Model/Order.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public Order(Option<bool?> complete = default, Option<long?> id = default, Optio
/// Gets or Sets Status
/// </summary>
[JsonPropertyName("status")]
public OrderStatus? Status { get { return this.StatusOption; } set { this.StatusOption = new(value); } }
public OrderStatus? Status { get { return this.StatusOption.Value; } set { this.StatusOption = new(value); } }

/// <summary>
/// Used to track the state of Complete
Expand Down
2 changes: 1 addition & 1 deletion ...les/client/petstore/csharp/generichost/net10/FormModels/src/Org.OpenAPITools/Model/Pet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public Pet(string name, List<string> photoUrls, Option<Category> category = defa
/// Gets or Sets Status
/// </summary>
[JsonPropertyName("status")]
public PetStatus? Status { get { return this.StatusOption; } set { this.StatusOption = new(value); } }
public PetStatus? Status { get { return this.StatusOption.Value; } set { this.StatusOption = new(value); } }

/// <summary>
/// Gets or Sets Name
Expand Down
Loading
Loading