[Java] Optimize All Enum fromValue Mustache Templates#23165
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Mar 9, 2026
Merged
[Java] Optimize All Enum fromValue Mustache Templates#23165wing328 merged 2 commits intoOpenAPITools:masterfrom
fromValue Mustache Templates#23165wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Contributor
Author
|
No sample files have been updated due to these changes 🎉 |
Contributor
There was a problem hiding this comment.
1 issue found across 23 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/enumClass.mustache">
<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/enumClass.mustache:35">
P1: Case-insensitive string-enum branch renders `equalsequalsIgnoreCase`, producing uncompilable generated Java.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Member
|
cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
Member
|
nice! let's give it a try |
davidricodias
pushed a commit
to davidricodias/openapi-generator
that referenced
this pull request
Mar 11, 2026
…#23165) * [Java] Optimize All Enum `fromValue` Mustache Templates Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com> * Fix JavaJaxRS Mustache Template Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com> --------- Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors/Optimizes the Mustache Templates for generating
fromValue-methods in Java Enum classes. This is solely a refactoring of the mustache templates, and will not affect the generated classes in any way.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Collapsed equals/equalsIgnoreCase branching in fromValue across all Java enum Mustache templates. No changes to generated code; case-insensitive matching for string enums is preserved.
Written for commit 715b70f. Summary will update on new commits.