Skip to content

[Java] Optimize All Enum fromValue Mustache Templates#23165

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
Chrimle:java-enum-fromvalue-opt
Mar 9, 2026
Merged

[Java] Optimize All Enum fromValue Mustache Templates#23165
wing328 merged 2 commits intoOpenAPITools:masterfrom
Chrimle:java-enum-fromvalue-opt

Conversation

@Chrimle
Copy link
Copy Markdown
Contributor

@Chrimle Chrimle commented Mar 7, 2026

Refactors/Optimizes the Mustache Templates for generating fromValue-methods in Java Enum classes. This is solely a refactoring of the mustache templates, and will not affect the generated classes in any way.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Collapsed equals/equalsIgnoreCase branching in fromValue across all Java enum Mustache templates. No changes to generated code; case-insensitive matching for string enums is preserved.

  • Refactors
    • Use b.value.equals{{#isString}}{{#useEnumCaseInsensitive}}IgnoreCase{{/useEnumCaseInsensitive}}{{/isString}}(value) to reduce Mustache conditionals.
    • Applied across core Java, OkHttp-Gson, JAX-RS (spec, cxf, cxf-ext, cxf-cdi), Spring, Play, Micronaut, Vert.x; includes a JAX-RS template fix to align with the new pattern.

Written for commit 715b70f. Summary will update on new commits.

Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
@Chrimle Chrimle marked this pull request as ready for review March 7, 2026 15:11
@Chrimle
Copy link
Copy Markdown
Contributor Author

Chrimle commented Mar 7, 2026

No sample files have been updated due to these changes 🎉

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 23 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/enumClass.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/enumClass.mustache:35">
P1: Case-insensitive string-enum branch renders `equalsequalsIgnoreCase`, producing uncompilable generated Java.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread modules/openapi-generator/src/main/resources/JavaJaxRS/cxf/enumClass.mustache Outdated
Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 23 files

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 9, 2026

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 9, 2026

nice!

let's give it a try

@wing328 wing328 merged commit 44bc527 into OpenAPITools:master Mar 9, 2026
15 checks passed
@wing328 wing328 added this to the 7.21.0 milestone Mar 9, 2026
@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Mar 9, 2026
davidricodias pushed a commit to davidricodias/openapi-generator that referenced this pull request Mar 11, 2026
…#23165)

* [Java] Optimize All Enum `fromValue` Mustache Templates

Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>

* Fix JavaJaxRS Mustache Template

Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>

---------

Signed-off-by: Chrimle <28791817+Chrimle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: Java Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants