Skip to content

[typescript-angular] Include OIDC credential headers#23065

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
rgroothuijsen:issue-21245
Feb 27, 2026
Merged

[typescript-angular] Include OIDC credential headers#23065
wing328 merged 1 commit intoOpenAPITools:masterfrom
rgroothuijsen:issue-21245

Conversation

@rgroothuijsen
Copy link
Copy Markdown
Contributor

@rgroothuijsen rgroothuijsen commented Feb 27, 2026

When OIDC security is defined, the authorization header is not included in the request. This is addressed by adding it in the same way that was used for OAuth.

Fixes #21245

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka @joscha @dennisameling

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Adds the missing Authorization header for OpenID Connect in the TypeScript Angular generator, matching the existing OAuth behavior. Fixes requests that omitted the Bearer token when OIDC security is defined (fixes #21245).

  • Bug Fixes
    • Set Authorization: Bearer header for OpenID schemes in api.service.mustache.
    • Added test (testOpenIdCredentialsAreSet) with a 3.1 spec to verify header generation.

Written for commit e60384c. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 27, 2026

lgtm. thanks for the contribution

@wing328 wing328 merged commit 8515f5e into OpenAPITools:master Feb 27, 2026
15 checks passed
davidricodias pushed a commit to davidricodias/openapi-generator that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Typescript/Angular generator does not handle authorization header for OIDC security schemes

2 participants