[dart] Fix enum defaults, Object arrays, and nullable required assertions in native serialization#23027
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Feb 23, 2026
Conversation
…sertions in native serialization
Member
|
thanks for the PR which has been merged |
Member
|
FYI @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08) |
davidricodias
pushed a commit
to davidricodias/openapi-generator
that referenced
this pull request
Mar 11, 2026
…ions in native serialization (OpenAPITools#23027) * fix(dart): fix enum defaults, Object arrays, and nullable required assertions in native serialization * update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs in the Dart native serialization codegen:
fromJsonfallback generated?? 'value_one'instead of?? const EnumType._('value_one'), causing a type mismatchObject.listFromJson()doesn't exist —Objectwas not inlanguageSpecificPrimitives, so Object-typed arrays generated invalidObject.listFromJson()calls instead ofcast<Object>()requiredKeys.forEachassertion block assertedjson[key] != nullfor all required fields, including nullable onesFixes #13459, fixes #20152, fixes #20296
Changes
AbstractDartCodegen.java"Object"tolanguageSpecificPrimitives(consistent with DartDio)native_class.mustacheconst {enumName}._()constructornative_class.mustacherequiredKeys.forEachwith per-property assertions respectingisNullableDartClientCodegenTest.javaTest plan
Summary by cubic
Fixes three Dart native serialization bugs: enum default deserialization, Object arrays, and required+nullable field assertions. Also updates docs to list Object as a language primitive in Dart and Dart-Dio.
Bug Fixes
Migration
Written for commit 1a9997f. Summary will update on new commits.