Skip to content

Replace mvnw with mvn in README.md because mvnw doesn't work with run-in-docker.sh#22975

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
sekikn:22974-fix-readme
Feb 15, 2026
Merged

Replace mvnw with mvn in README.md because mvnw doesn't work with run-in-docker.sh#22975
wing328 merged 1 commit intoOpenAPITools:masterfrom
sekikn:22974-fix-readme

Conversation

@sekikn
Copy link
Copy Markdown
Contributor

@sekikn sekikn commented Feb 14, 2026

PR checklist

  • Read the contribution guidelines.

  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.

  • Run the following to build the project and update samples:

    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    

    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.

    Not required since it's just a minor documentation fix

  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)

  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)

    fixes [BUG] The section about development in docker in README.md has incorrect commands #22974

  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.


Summary by cubic

Update README to replace mvnw with mvn in run-in-docker.sh examples and troubleshooting, since mvnw doesn’t work inside the Docker container. Fixes #22974 and prevents build failures when following the docs.

Written for commit 262ebcd. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wing328 wing328 merged commit ff7fd36 into OpenAPITools:master Feb 15, 2026
15 checks passed
@wing328 wing328 added this to the 7.20.0 milestone Feb 15, 2026
padznich pushed a commit to padznich/openapi-generator that referenced this pull request Feb 16, 2026
davidricodias pushed a commit to davidricodias/openapi-generator that referenced this pull request Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] The section about development in docker in README.md has incorrect commands

2 participants