Skip to content

[BUG] [java-camel] Align pom.xml generation with the documentation#22888

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
sekikn:22887-java-camel-fix-pom-generation
Feb 3, 2026
Merged

[BUG] [java-camel] Align pom.xml generation with the documentation#22888
wing328 merged 1 commit intoOpenAPITools:masterfrom
sekikn:22887-java-camel-fix-pom-generation

Conversation

@sekikn
Copy link
Copy Markdown
Contributor

@sekikn sekikn commented Feb 3, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

fixes #22887

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg (mentioning the Java technical committee, since there seems no committee for java-camel specifically)


Summary by cubic

Aligns java-camel pom.xml generation with the docs by selecting the correct Swagger/OpenAPI annotations via annotationLibrary and removing outdated flags. This ensures the generated POM includes only the expected annotations dependency. Fixes #22887.

  • Bug Fixes
    • Default to OpenAPI v3 annotations via annotationLibrary, not the old oas3 flag.
    • Update pom.mustache to conditionally include swagger-annotations 1.x or 2.x based on annotationLibrary.
    • Remove legacy oas3 and library settings from the sample config.
    • Regenerate sample POM to drop the 1.x swagger-annotations dependency.

Written for commit 5099630. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@wing328 wing328 merged commit a25bed7 into OpenAPITools:master Feb 3, 2026
29 checks passed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 3, 2026

thanks for the contribution, which has been merged

@wing328 wing328 added this to the 7.20.0 milestone Feb 3, 2026
@sekikn sekikn deleted the 22887-java-camel-fix-pom-generation branch February 3, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [java-camel] pom.xml is not generated by default despite the documentation

2 participants