Skip to content

Remove deprecated compiler option from TS Fetch tests#22871

Merged
wing328 merged 1 commit intomasterfrom
fix-ts-fetch-test
Feb 2, 2026
Merged

Remove deprecated compiler option from TS Fetch tests#22871
wing328 merged 1 commit intomasterfrom
fix-ts-fetch-test

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Feb 2, 2026

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Use Mocha’s --require ts-node/register in TypeScript Fetch sample tests instead of the deprecated --compilers flag to ensure compatibility with newer Mocha versions.

Written for commit 71c3fa4. Summary will update on new commits.

@wing328 wing328 changed the title Remove compiler option from TS Fetch tests Remove deprecated compiler option from TS Fetch tests Feb 2, 2026
@wing328 wing328 marked this pull request as ready for review February 2, 2026 05:37
@wing328 wing328 added this to the 7.20.0 milestone Feb 2, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@wing328 wing328 merged commit 41a8573 into master Feb 2, 2026
52 checks passed
@wing328 wing328 deleted the fix-ts-fetch-test branch February 2, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant