Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="samples/client/petstore/R-httr2/tests/testthat/test_petstore.R">
<violation number="1" location="samples/client/petstore/R-httr2/tests/testthat/test_petstore.R:98">
P2: Avoid commenting out tests; use testthat::skip() or conditional skipping so the suite still records the test as skipped and coverage intent is preserved.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| ApiException = function(ex) ex | ||
| ) | ||
| }) | ||
| #test_that("update_pet_with_form", { |
Contributor
There was a problem hiding this comment.
P2: Avoid commenting out tests; use testthat::skip() or conditional skipping so the suite still records the test as skipped and coverage intent is preserved.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At samples/client/petstore/R-httr2/tests/testthat/test_petstore.R, line 98:
<comment>Avoid commenting out tests; use testthat::skip() or conditional skipping so the suite still records the test as skipped and coverage intent is preserved.</comment>
<file context>
@@ -95,52 +95,52 @@ test_that("get_pet_by_id", {
- ApiException = function(ex) ex
- )
-})
+#test_that("update_pet_with_form", {
+# ## add pet
+# update_pet_id <- 123999
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Update R samples CI to include R-httr2 and R-httr2-wrapper, adding them to workflow path filters and the build matrix so they run on push and PR. Commented out httr2 tests for update_pet_with_form and get_pet_by_id_streaming, disabled find_pets_by_tags in the wrapper to stabilize runs, and added placeholder comment lines to the R-httr2 .openapi-generator-ignore.
Written for commit 165549d. Summary will update on new commits.