Skip to content

Improve sample update with better exception handling#22670

Merged
wing328 merged 6 commits intomasterfrom
improve-test
Jan 11, 2026
Merged

Improve sample update with better exception handling#22670
wing328 merged 6 commits intomasterfrom
improve-test

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Jan 11, 2026

Improve sample update with better exception handling

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Improved sample generation to detect exceptions early and cleaned up test specs and sample outputs to avoid invalid schemas and misleading names.

  • Bug Fixes

    • generate-samples.sh now flags an error and prints a message if generator logs contain “exception”.
  • Refactors

    • Renamed sample/config output dirs to java-play-framework-no-excp-handling and spring-boot-defaultInterface-unhandledExcp, and updated CI workflows.
    • Fixed OpenAPI test specs by replacing “type: object” + $ref with a direct $ref in oneOf/anyOf.
    • Moved null request body coverage into enum-implements.yaml and removed the nullRequestBody endpoint from the okhttp-gson client sample (README, docs, API class, openapi.yaml).

Written for commit 440be08. Summary will update on new commits.

@wing328 wing328 changed the title Improve test Improve sample update with better exception handling Jan 11, 2026
@wing328 wing328 marked this pull request as ready for review January 11, 2026 10:45
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 111 files

Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="modules/openapi-generator/src/test/resources/3_0/enum-implements.yaml">

<violation number="1" location="modules/openapi-generator/src/test/resources/3_0/enum-implements.yaml:76">
P2: A schema object cannot define both `type` and `$ref`; this `oneOf` entry should reference `OneOf1` directly instead of combining it with inline keywords.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment on lines +76 to +77
- type: object
"$ref": "#/components/schemas/OneOf1"
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: A schema object cannot define both type and $ref; this oneOf entry should reference OneOf1 directly instead of combining it with inline keywords.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/test/resources/3_0/enum-implements.yaml, line 76:

<comment>A schema object cannot define both `type` and `$ref`; this `oneOf` entry should reference `OneOf1` directly instead of combining it with inline keywords.</comment>

<file context>
@@ -17,6 +17,64 @@ paths:
+                  - type: array
+                    items:
+                      "$ref": "#/components/schemas/OneOf1"
+                  - type: object
+                    "$ref": "#/components/schemas/OneOf1"
 components:
</file context>
Suggested change
- type: object
"$ref": "#/components/schemas/OneOf1"
+ - $ref: '#/components/schemas/OneOf1'
Fix with Cubic

@wing328 wing328 added this to the 7.19.0 milestone Jan 11, 2026
@wing328 wing328 merged commit 23dae2b into master Jan 11, 2026
183 checks passed
@wing328 wing328 deleted the improve-test branch January 11, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant