Improve sample update with better exception handling#22670
Merged
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 111 files
Note: This PR contains a large number of files. cubic only reviews up to 75 files per PR, so some files may not have been reviewed.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="modules/openapi-generator/src/test/resources/3_0/enum-implements.yaml">
<violation number="1" location="modules/openapi-generator/src/test/resources/3_0/enum-implements.yaml:76">
P2: A schema object cannot define both `type` and `$ref`; this `oneOf` entry should reference `OneOf1` directly instead of combining it with inline keywords.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Comment on lines
+76
to
+77
| - type: object | ||
| "$ref": "#/components/schemas/OneOf1" |
Contributor
There was a problem hiding this comment.
P2: A schema object cannot define both type and $ref; this oneOf entry should reference OneOf1 directly instead of combining it with inline keywords.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/test/resources/3_0/enum-implements.yaml, line 76:
<comment>A schema object cannot define both `type` and `$ref`; this `oneOf` entry should reference `OneOf1` directly instead of combining it with inline keywords.</comment>
<file context>
@@ -17,6 +17,64 @@ paths:
+ - type: array
+ items:
+ "$ref": "#/components/schemas/OneOf1"
+ - type: object
+ "$ref": "#/components/schemas/OneOf1"
components:
</file context>
Suggested change
| - type: object | |
| "$ref": "#/components/schemas/OneOf1" | |
| + - $ref: '#/components/schemas/OneOf1' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve sample update with better exception handling
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Improved sample generation to detect exceptions early and cleaned up test specs and sample outputs to avoid invalid schemas and misleading names.
Bug Fixes
Refactors
Written for commit 440be08. Summary will update on new commits.