Skip to content

[BUG][ASPNETCORE] Fallback to HttpContext as resource in authorization handler #22617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alec-petersen wants to merge 2 commits into from
Closed

[BUG][ASPNETCORE] Fallback to HttpContext as resource in authorization handler #22617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a38a54f
Fallback to regular HttpContext if context is not an AuthorizationFil…
alec-petersen Jan 4, 2026
2e1176c
Update samples
alec-petersen Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions ...api-generator/src/main/resources/aspnetcore/3.0/Authentication/ApiAuthentication.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace {{packageName}}.Authentication
Expand Down Expand Up @@ -48,24 +49,29 @@ namespace {{packageName}}.Authentication

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
{{#authMethods}}{{#isApiKey}}
if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
{
{{#authMethods}}
{{#isApiKey}}
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (httpContext == null)
return;

{{#isKeyInHeader}}
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["{{keyParamName}}"].FirstOrDefault();
var apiKey = httpContext.Request.Headers["{{keyParamName}}"].FirstOrDefault();
{{/isKeyInHeader}}
{{#isKeyInQuery}}
var apiKey = authorizationFilterContext.HttpContext.Request.Query["{{keyParamName}}"].FirstOrDefault();
var apiKey = httpContext.Request.Query["{{keyParamName}}"].FirstOrDefault();
{{/isKeyInQuery}}
{{#isKeyInCookie}}
var apiKey = authorizationFilterContext.HttpContext.Request.Cookies["{{keyParamName}}"] ?? null;
var apiKey = httpContext.Request.Cookies["{{keyParamName}}"] ?? null;
{{/isKeyInCookie}}
if (requirement.PolicyName == "{{name}}" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
if (requirement.PolicyName == "{{name}}" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
{{/isApiKey}}{{/authMethods}}
{{/isApiKey}}
{{/authMethods}}
}
}
}
16 changes: 9 additions & 7 deletions ...s/server/petstore/aspnetcore-3.0/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...s/server/petstore/aspnetcore-3.1/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...s/server/petstore/aspnetcore-5.0/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...e/aspnetcore-6.0-NewtonsoftFalse/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...tcore-6.0-nullableReferenceTypes/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...tstore/aspnetcore-6.0-pocoModels/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...re/aspnetcore-6.0-project4Models/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...re/aspnetcore-6.0-useSwashBuckle/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...s/server/petstore/aspnetcore-6.0/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
16 changes: 9 additions & 7 deletions ...e/aspnetcore-8.0-NewtonsoftFalse/src/Org.OpenAPITools/Authentication/ApiAuthentication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc.Filters;

namespace Org.OpenAPITools.Authentication
Expand Down Expand Up @@ -57,16 +58,17 @@ protected override Task HandleRequirementAsync(AuthorizationHandlerContext conte

private void SucceedRequirementIfApiKeyPresentAndValid(AuthorizationHandlerContext context, ApiKeyRequirement requirement)
{
var httpContext = (context.Resource as AuthorizationFilterContext)?.HttpContext
?? context.Resource as HttpContext;

if (context.Resource is AuthorizationFilterContext authorizationFilterContext)
if (httpContext == null)
return;

var apiKey = httpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
var apiKey = authorizationFilterContext.HttpContext.Request.Headers["api_key"].FirstOrDefault();
if (requirement.PolicyName == "api_key" && apiKey != null && requirement.ApiKeys.Any(requiredApiKey => apiKey == requiredApiKey))
{
context.Succeed(requirement);
}
context.Succeed(requirement);
}

}
}
}
Loading
Loading