[java] fix: five nondeterministic tests#22513
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 9, 2025
Merged
Conversation
7f9a0cd to
f2ffeed
Compare
lucy66hw
pushed a commit
to lucy66hw/openapi-generator
that referenced
this pull request
Dec 16, 2025
rajvesh
pushed a commit
to rajvesh/openapi-generator
that referenced
this pull request
Dec 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fix five non-deterministic tests that are detected by NonDex, a tool for detecting wrong assumptions on under-determined Java APIs.
Problem
In
ExampleGeneratorTest(generateFromResponseSchemaWithAllOfChildComposedModel,generateFromResponseSchemaWithAllOfComposedModel, andgenerateFromResponseSchemaWithDateFormat):The test compared the generated example against a single hard-coded JSON string. When the underlying JSON object fields were emitted in a different order, the assertion failed even though the structure and values were correct.
JavaClientCodegenTest.testNotDuplicateOauth2FlowsScopes:This test assumed a fixed iteration order of
getWithBasicAuthAndOauth.authMethodsandgetWithOauthAuth.authMethods, i.e., that index0would always bebasic_authand subsequent entries would always correspond to specific OAuth2 flows. Under NonDex, the backing collection order can change, causing intermittent failures.JetbrainsHttpClientClientCodegenTest.testBasicGenerationManyAuths:The test relied on a specific block layout in the generated
.httpfile. NonDeterminism in generation (e.g., heading level changes or header ordering) caused the entire assertion to fail even when the essential content was still present.To reproduce the failures, run NonDex on
modules/openapi-generatorusing the following commands:Replace
packageName.ClassName#methodNamewith one of:The Fix
In
ExampleGeneratorTest(generateFromResponseSchemaWithAllOfChildComposedModel,generateFromResponseSchemaWithAllOfComposedModel, andgenerateFromResponseSchemaWithDateFormat):Construct an
ObjectMapperand compareJsonNodebymapper.readTree(...)for both the expected JSON andexamples.get(0).get("example"), so the assertion focuses on field values while ignoring non-deterministic JSON key ordering.JavaClientCodegenTest.testNotDuplicateOauth2FlowsScopes:Copy
authMethodsinto new lists and sort them bynamebefore performing assertions. This keeps the intent while avoiding reliance on the original collection iteration order.JetbrainsHttpClientClientCodegenTest.testBasicGenerationManyAuths:Update the assertions to check that the generated .http file contains the expected sections, request lines, and headers regardless of their order or heading level, instead of depending on a single fixed layout.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)