[csharp] Handling of nullable and required properties#22278
Open
Bouillie wants to merge 44 commits intoOpenAPITools:8.0.xfrom
Open
[csharp] Handling of nullable and required properties#22278Bouillie wants to merge 44 commits intoOpenAPITools:8.0.xfrom
Bouillie wants to merge 44 commits intoOpenAPITools:8.0.xfrom
Conversation
added 30 commits
October 30, 2025 14:19
- Not required fields are wrapped in an Option struct - Nullable field use "?" when appropriate - Breaking changes, as non required fields previously used "?" # Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CSharpClientCodegen.java # modules/openapi-generator/src/main/resources/csharp/modelGeneric.mustache
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/CSharpClientCodegen.java
# Conflicts: # modules/openapi-generator/src/main/resources/csharp/api.mustache # modules/openapi-generator/src/main/resources/csharp/libraries/httpclient/api.mustache # modules/openapi-generator/src/main/resources/csharp/libraries/unityWebRequest/api.mustache # modules/openapi-generator/src/test/java/org/openapitools/codegen/csharpnetcore/CSharpOperationTest.java
# Conflicts: # modules/openapi-generator/src/main/resources/csharp/libraries/httpclient/api.mustache
# Conflicts: # modules/openapi-generator/src/main/resources/csharp/api.mustache # modules/openapi-generator/src/main/resources/csharp/libraries/unityWebRequest/api.mustache
# Conflicts: # modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenConstants.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java # modules/openapi-generator/src/main/resources/csharp/api.mustache # modules/openapi-generator/src/main/resources/csharp/libraries/httpclient/api.mustache # modules/openapi-generator/src/main/resources/csharp/libraries/unityWebRequest/api.mustache
# Conflicts: # samples/client/petstore/csharp/restsharp/net7/EnumMappings/src/Org.OpenAPITools/Client/ApiClient.cs
…e behaviour stays the same
added 9 commits
November 3, 2025 12:50
Contributor
Author
|
I've checked the failing tests.
|
added 5 commits
November 4, 2025 11:03
- also, remove the last GENERICHOST reference remaining
getNullablePropertyType to getNullableTypeDeclaration
Contributor
|
Surprised this has sat for a while, if these libraries continue to be supported, this should be getting a lot of attention as it fixes a hard to solve long standing issue. I do have a few thoughts though.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update concerns the restsharp, httpclient and unitywebrequest libraries.
Example of generated code:
public int RequiredNotnullableintegerProp { get; set; }public int? RequiredNullableIntegerProp { get; set; }public Option<int?> NotRequiredNullableIntegerProp { get; set; }public Option<int> NotRequiredNotnullableintegerProp { get; set; }Those are breaking changes because of the type change of fields and function parameters from
T?toOption<T>Notes : I made sure not to impact the generichost library as it already handles Options. I also took null reference types into account.
Fixes: #22254 #21090
@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)