Skip to content

[Spring] Optimize and omit unnecessary imports on Api in ApiController templates#22164

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
daberni:feature/NativeWebRequest
Oct 18, 2025
Merged

[Spring] Optimize and omit unnecessary imports on Api in ApiController templates#22164
wing328 merged 3 commits intoOpenAPITools:masterfrom
daberni:feature/NativeWebRequest

Conversation

@daberni
Copy link
Copy Markdown
Contributor

@daberni daberni commented Oct 16, 2025

This change optimizes the import statements of Spring templates to not import types used for Default Interface and Delegate implementations.

Additionally remove redundant additionalProperty with identical logic.

Additionally gets rid of an unnecessary blank line.

@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@daberni daberni marked this pull request as ready for review October 16, 2025 21:18
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 18, 2025

thanks for the pr. looks good

let's give it a try

have a nice weekend

@wing328 wing328 merged commit 2b00bab into OpenAPITools:master Oct 18, 2025
64 checks passed
@wing328 wing328 added Server: Spring Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Java labels Oct 18, 2025
@wing328 wing328 added this to the 7.17.0 milestone Oct 18, 2025
@daberni daberni deleted the feature/NativeWebRequest branch October 21, 2025 20:02
rajvesh pushed a commit to rajvesh/openapi-generator that referenced this pull request Dec 25, 2025
…r templates (OpenAPITools#22164)

* Optimize imports

* remove unnecessary blank line

* revert unintended indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Server: Java Server: Spring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants