Jersey2/3: Allow multiple MIME-types in Accept-Header (WIP)#22135
Open
jheyens wants to merge 2 commits intoOpenAPITools:masterfrom
Open
Jersey2/3: Allow multiple MIME-types in Accept-Header (WIP)#22135jheyens wants to merge 2 commits intoOpenAPITools:masterfrom
jheyens wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
515e130 to
e20e33f
Compare
e20e33f to
d6991eb
Compare
Member
|
thanks for the PR can you please update the tests so that the CI tests will pass? |
Contributor
Author
|
Unfortunately, not directly, since there is still an issue:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of an endpoint that may reply with multiple Content-Types where one of them matches a regex checking for JSON-MIME-types (e.g. a file as application/octet-stream if successful and an error message as application/json in case of an error), the Jersey code will ignore all non-JSON MIME-types. This is an issue if the REST-server checks whether user agents are even able to handle the response format by evaluating the "Accept: "-request header (which it should).
I consider this PR a WIP, since there might be reasons for ignoring non-JSON types that I am not aware of.
There also seems to be an issue with three of the petstore samples not being able to handle
application/xml(e.g. https://github.com/DIaLOGIKa-GmbH/openapi-generator/actions/runs/18501770033/job/52720236107). I'ld like a discussion on why other MIME-types are discarded and how we could resolve both of these issues.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)@bbdouglas
@sreeshas
@jfiala
@lukoyanov
@cbornet
@jeff9finger
@karismann
@Zomzog
@lwlee2608
@martin-mfg