Use Pydantic for json serialization in .to_json method#22111
Closed
EspenHa wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
Use Pydantic for json serialization in .to_json method#22111EspenHa wants to merge 2 commits intoOpenAPITools:masterfrom
EspenHa wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
2f29196 to
4863b63
Compare
Contributor
Author
|
Tests seem to be failing due to differences in how json is generated in Python's stdlib json module, and pydantic. I might come back and fix this later if there is interest for moving this PR forward. |
Member
|
@EspenHa thanks for the PR can you please PM me via Slack to discuss this further? |
7f429d4 to
585521b
Compare
585521b to
d694e9a
Compare
Contributor
Author
|
@wing328 I added tests for serializing UUIDs. This PR should be ready to merge. |
|
We're facing an issue with |
6 tasks
Member
|
merged via #23210 with update samples and all tests passed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the
to_jsonmethod of generated models to usePydantic's
to_jsonable_python, to ensure that the input tojson.dumpsonly contains serializable types.This fixes #22063.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)