Skip to content

[python] style: add a space before comment text in .gitignore#21844

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
CatBraaain:python-style-gitignore
Aug 31, 2025
Merged

[python] style: add a space before comment text in .gitignore#21844
wing328 merged 1 commit intoOpenAPITools:masterfrom
CatBraaain:python-style-gitignore

Conversation

@CatBraaain
Copy link
Copy Markdown
Contributor

Just adding a space before the comment text in .gitignore for readability.
No functional changes.

-#Ipython Notebook
+# Ipython Notebook

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@CatBraaain CatBraaain changed the title style: add a space before comment text in .gitignore [python] style: add a space before comment text in .gitignore Aug 30, 2025
@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 31, 2025

thanks for the PR

cc @cbornet (2017/09) @tomplus (2018/10) @krjakbrjak (2023/02) @fa0311 (2023/10) @multani (2023/10)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 31, 2025

CI failure not related to this change

@wing328 wing328 merged commit d8593ef into OpenAPITools:master Aug 31, 2025
52 of 57 checks passed
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
@wing328 wing328 added this to the 7.16.0 milestone Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants