Skip to content

[Rust] fix: add location prefix to prevent parameter name collisions#21611

Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom
andershausding:master
Aug 12, 2025
Merged

[Rust] fix: add location prefix to prevent parameter name collisions#21611
wing328 merged 4 commits intoOpenAPITools:masterfrom
andershausding:master

Conversation

@andershausding
Copy link
Copy Markdown
Contributor

…when escaping parameter names

Fixes #21610

Generated code from test.yaml will result in this code:

pub async fn test_name_post (...) {
    // add a prefix to parameters to efficiently prevent name collisions
    let p_path_name = name;
    let p_body_body_request = body_request;
    let p_query_name = name2;
    let p_header_name = name3;
    let p_cookie_name = name4;
    (...)
}

@frol @farcaller @richardwhiuk @paladinzh @jacob-pro

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Aug 12, 2025

thanks for the PR

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) @jacob-pro (2022/10) @dsteeley (2025/07)

@wing328 wing328 merged commit 1860efa into OpenAPITools:master Aug 12, 2025
61 checks passed
@wing328 wing328 added this to the 7.15.0 milestone Aug 22, 2025
Goopher pushed a commit to Goopher/openapi-generator that referenced this pull request Sep 9, 2025
…penAPITools#21611)

* [Rust] fix: add location prefix to prevent parameter name collisions when escaping parameter names

* chore: update samples

* [Rust] fix: do not use locationSuffix if useSingleRequestParameter feature is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [Rust] Request parameter name collision

2 participants