Replace deprecated to_dict with model_dump for Pydantic v2 compatibility#21289
Closed
timonrieger wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
Replace deprecated to_dict with model_dump for Pydantic v2 compatibility#21289timonrieger wants to merge 1 commit intoOpenAPITools:masterfrom
to_dict with model_dump for Pydantic v2 compatibility#21289timonrieger wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
to_dict method with `model_d…to_dict with model_dump for Pydantic v2 compatibility
Member
|
thanks for the pr can you please the ci test failure when you've time? |
Contributor
Author
|
yes will do! |
Contributor
Author
|
oh my bad actually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates code generation to replace the deprecated
to_dict()method from Pydantic v2 models with the recommendedmodel_dump()method.Verified that generated models using Pydantic v2 successfully serialize with
model_dump()and produce the same output as before by running a unittest with this code.PR checklist
./mvnw clean package || exit ./bin/generate-samples.sh ./bin/configs/*.yaml || exit ./bin/utils/export_docs_generators.sh || exit(For Windows users, please run the script in WSL)
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking change$