[ci][elixir] check if formatting is valid#21285
[ci][elixir] check if formatting is valid#21285efcasado wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
|
please have a look at https://github.com/OpenAPITools/openapi-generator/actions/runs/15049963932/job/42302322976?pr=21285 when you've time for other language/generator, we usually don't check the format in the CI as it's sometimes quite hard format the output in a particular way using mustache templates we recommend users to run code formatter/linter post code generation (e.g. there's a maven/gradle task to format the auto-generated Java code based on rules in an XML file) |
|
It seems there might be good reasons why this check was excluded in the first place? The "Samples up-to-date" check runs the |
exactly! |
|
Makes sense! I will close this |
Description
This pull request builds on #21214 by adding a check to ensure that files generated by the Elixir generator are correctly formatted according to the provided formatter.exs configuration.
All files under
/samples/client/petstore/elixir,including test files, have been formatted using mix format.This improves overall consistency, readability, and maintainability by enforcing standardized formatting across the project.
@wing328, @mrmstn - As usual, curious to hear your thoughts on this one 😊 It does not add any new functionality, but I feel it can help us improve the overall developer experience when it comes to contributing to the project.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)