Skip to content

[protobuf-schema] Remove 'model/' prefix from Protobuf imports for mapped custom packages#20946

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
lucy66hw:import
Mar 22, 2025
Merged

[protobuf-schema] Remove 'model/' prefix from Protobuf imports for mapped custom packages#20946
wing328 merged 1 commit intoOpenAPITools:masterfrom
lucy66hw:import

Conversation

@lucy66hw
Copy link
Copy Markdown
Contributor

This PR fixes the issue by removing the "model/" prefix from imports that are explicitly mapped through importMapping. The generator now correctly handles standard protobuf types and ensures generated files compile successfully.

Example of Incorrect Import:
import "model/google/protobuf/struct.proto";
Now:
import "google/protobuf/struct.proto";

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 merged commit f399910 into OpenAPITools:master Mar 22, 2025
18 checks passed
@wing328 wing328 added this to the 7.13.0 milestone Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants