adjusted csharp codegen to allow for nullable properties

[BryanAldrich]

For value types only unless nullable reference types is enabled.

Edited tests to compensate for the actual data types. They were optional/not-required in the yaml, but came back with non-nullable types.

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in Git BASH)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

[devhl-labs]

Looks good, but embedding the question mark in the data type is something we should try to remove eventually. We can use the nullable property, x-is-value-type, or x-is-nullable-type (true for value or nrt enabled). I've already handled it for generichost.

[BryanAldrich]

So, you're saying to add {{^required}}{{nrt?}}{{^nrt}}{{#vendorExtensions.x-is-value-type}}?{{/vendorExtensions.x-is-value-type}}{{/nrt}} {{/required}} in the mustache template on the properties (i copied that from the generichost template). And then remove the java edit?

[devhl-labs]

Yes, that is one way. We could also add a vendor extension to concat the data type and the ? if we like. This is just a suggestion for a future pr though, you can leave this alone if you want.

[wing328]

have you tried enabling SET_PRIMITIVE_TYPES_TO_NULLABLE in normalizer? i think that should meet your requirement.

https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#openapi-normalizer

[BryanAldrich]

@wing328 that flag seems to set the IsNullable to true if it truly is, however, the csharp template still wasn't writing out the nullable ? to the .cs files.