Skip to content

[C][Client] Add GitHub Action to test c client sample build#15922

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-c-action-0625
Jun 27, 2023
Merged

[C][Client] Add GitHub Action to test c client sample build#15922
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-c-action-0625

Conversation

@ityuhui
Copy link
Copy Markdown
Contributor

@ityuhui ityuhui commented Jun 26, 2023

This PR adds a GitHub Action to test c client sample build to address #15782 (comment)

@wing328 @zhemant (2018/11) @ityuhui (2019/12) @michelealbano (2020/03)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ityuhui ityuhui requested a review from jimschubert as a code owner June 26, 2023 03:44
@ityuhui
Copy link
Copy Markdown
Contributor Author

ityuhui commented Jun 26, 2023

I've tested this Action on my forked repo:

https://github.com/ityuhui/openapi-generator/actions/runs/5373533420/jobs/9748005651

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 27, 2023

Nice 👍

@wing328 wing328 merged commit 47f2f5f into OpenAPITools:master Jun 27, 2023
@ityuhui ityuhui deleted the yh-c-action-0625 branch June 27, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants