Merged
Conversation
BatyLeo
requested changes
Jan 9, 2026
Member
BatyLeo
left a comment
BatyLeo
left a comment
There was a problem hiding this comment.
Very clean first Pull Request!
Here are some comments. Additionally, some tests are failing:
- To fix JuliaFormatter tests, you need to run JuliaFormatter formatting:
] add JuliaFormatter@v1 # you need to use version 1.x (not the latest version 2.x)
using JuliaFormatter, DecisionFocusedLearningBenchmarks
format(DecisionFocusedLearningBenchmarks)
- Since you changed the
observeoutput of DAP, one the failing tests need to be adjusted - Documentation is failing because it needs a
Maintenancesection in theapi.mdfile that imports docstrings. Also, it would be nice to add a documentation page describing the mathematical formulation of the Maintenance problem. For this, just create amaintenance.mdfile in thebenchmarksfolder in the documentation. See the example for DAP here.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes