Skip to content

fix: intent filters#2055

Merged
RohitKushvaha01 merged 1 commit intoAcode-Foundation:mainfrom
RohitKushvaha01:main
Apr 21, 2026
Merged

fix: intent filters#2055
RohitKushvaha01 merged 1 commit intoAcode-Foundation:mainfrom
RohitKushvaha01:main

Conversation

@RohitKushvaha01
Copy link
Copy Markdown
Member

@RohitKushvaha01 RohitKushvaha01 commented Apr 21, 2026

This pr fixes login issue + added explicit intent data filters

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 21, 2026

Greptile Summary

This PR fixes the file-opening intent filter by splitting the single <data android:mimeType=\"*/*\"/> element into two explicit scheme-scoped entries (file:// and content://), which correctly restricts the filter to local and provider-served URIs. It also consolidates the two previously duplicated edit-config blocks (one targeting AndroidManifest.xml and one targeting app/src/main/AndroidManifest.xml) into a single, properly-formed block targeting app/src/main/AndroidManifest.xml with all attributes in one <application> element — removing the now-deleted block that carried a comment saying "Cordova does not merge this unless both of these are present."

Confidence Score: 4/5

Safe to merge after verifying the edit-config consolidation doesn't regress Cordova manifest merging on a full build.

The intent-filter fix is correct and the edit-config consolidation is cleaner XML. The only real risk is the removal of the AndroidManifest.xml companion edit-config block (which had a comment explicitly warning it was required for Cordova to merge); if that comment was still valid for the current Cordova version, the application attributes could silently fail to merge. A single build and smoke-test would confirm. The missing trailing newline is a trivial P2.

config.xml — specifically the removed AndroidManifest.xml edit-config block and the missing trailing newline.

Important Files Changed

Filename Overview
config.xml Consolidates duplicate edit-config blocks into a single app/src/main/AndroidManifest.xml target, adds explicit file/content scheme data elements to the file-opening intent filter, and drops the previously-required companion AndroidManifest.xml edit-config block; missing trailing newline introduced.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[External Intent: Open File] --> B{Intent has data URI?}
    B -- No --> C[No match]
    B -- Yes --> D{Scheme?}
    D -- file:// --> E{MIME type?}
    D -- content:// --> F{MIME type?}
    D -- other e.g. http:// --> C
    E -- */* any --> G[App handles intent ✅]
    E -- no MIME --> C
    F -- */* any --> G
    F -- no MIME --> C

    style G fill:#4CAF50,color:#fff
    style C fill:#f44336,color:#fff
Loading

Reviews (1): Last reviewed commit: "fix: intent filters" | Re-trigger Greptile

Comment thread config.xml
Copy link
Copy Markdown
Member

@UnschooledGamer UnschooledGamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope it builds well, and is tested well enough.

@RohitKushvaha01 RohitKushvaha01 added the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Apr 21, 2026
@github-actions github-actions Bot removed the CI: RUN ON-DEMAND PREVIEW RELEASES Triggers an on-demand preview build for this pull request via CI workflow. label Apr 21, 2026
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

Preview Release for this, has been built.

Click here to view that github actions build

@RohitKushvaha01 RohitKushvaha01 merged commit 87550ae into Acode-Foundation:main Apr 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants