fix: intent filters#2055
Conversation
Greptile SummaryThis PR fixes the file-opening intent filter by splitting the single Confidence Score: 4/5Safe to merge after verifying the edit-config consolidation doesn't regress Cordova manifest merging on a full build. The intent-filter fix is correct and the edit-config consolidation is cleaner XML. The only real risk is the removal of the AndroidManifest.xml companion edit-config block (which had a comment explicitly warning it was required for Cordova to merge); if that comment was still valid for the current Cordova version, the application attributes could silently fail to merge. A single build and smoke-test would confirm. The missing trailing newline is a trivial P2. config.xml — specifically the removed AndroidManifest.xml edit-config block and the missing trailing newline. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[External Intent: Open File] --> B{Intent has data URI?}
B -- No --> C[No match]
B -- Yes --> D{Scheme?}
D -- file:// --> E{MIME type?}
D -- content:// --> F{MIME type?}
D -- other e.g. http:// --> C
E -- */* any --> G[App handles intent ✅]
E -- no MIME --> C
F -- */* any --> G
F -- no MIME --> C
style G fill:#4CAF50,color:#fff
style C fill:#f44336,color:#fff
Reviews (1): Last reviewed commit: "fix: intent filters" | Re-trigger Greptile |
UnschooledGamer
left a comment
There was a problem hiding this comment.
LGTM, I hope it builds well, and is tested well enough.
This comment has been minimized.
This comment has been minimized.
|
Preview Release for this, has been built. |
This pr fixes login issue + added explicit intent data filters