Update string tests

Author: padelsbach

tools/unit-tests/unit-string.c

@@ -48,6 +48,38 @@ static void reset_uart_buf(void)
     uart_len = 0;
 }
 
+#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
+
+/* Max length field value in strnlen, etc. Test strings must be shorter 
+ * than this value. */
+#define STRNCMP_MAX 64
+
+/* Function pointer type for strncmp-like functions */
+typedef int (*strncmp_fn_t)(const char*, const char*, size_t);
+
+/* Test case data */
+typedef struct {
+    strncmp_fn_t strncmp_fn;    /* strncmp or strncasecmp */
+    const char* s1;             /* First string to compare */
+    const char* s2;             /* Second string to compare */
+} strcmp_test_case_t;
+
+static void test_strncasecmp_eq(const strcmp_test_case_t* test_cases, size_t test_cases_num)
+{
+    strncmp_fn_t fn = test_cases[0].strncmp_fn;
+    for (size_t i = 0; i < test_cases_num; i++) {
+        for (unsigned j = 0; j < STRNCMP_MAX; j++) {
+            ck_assert_int_eq(fn(
+                test_cases[i].s1,
+                test_cases[i].s2, j), 0);
+            /* Swap string params */
+            ck_assert_int_eq(fn(
+                test_cases[i].s2,
+                test_cases[i].s1, j), 0);
+        }
+    }
+}
+
 START_TEST(test_strncasecmp_n_zero)
 {
     ck_assert_int_eq(strncasecmp("ABC", "abc", 0), 0);
@@ -94,9 +126,13 @@ END_TEST
 
 START_TEST(test_strcasecmp_mixed_alnum_punct)
 {
-    ck_assert_int_eq(strcasecmp("Boot-123_OK!", "bOot-123_ok!"), 0);
-    ck_assert_int_eq(strcasecmp("v1.2.3-rc1", "V1.2.3-RC1"), 0);
-    ck_assert_int_eq(strcasecmp("A_B-C.D", "a_b-c.d"), 0);
+    static const strcmp_test_case_t test_cases[] = {
+        { "Boot-123_OK!", "bOot-123_ok!", 0 },
+        { "v1.2.3-rc1", "V1.2.3-RC1", 0 },
+        { "A_B-C.D", "a_b-c.d", 0 },
+    };
+
+    test_strncasecmp_eq(test_cases, ARRAY_SIZE(test_cases));
 }
 END_TEST