Skip to content

Commit 6904f36

Browse files
rizlikdanielinux
authored andcommitted
disk.c: part_read/write remove len and simplify casting
1 parent d149077 commit 6904f36

1 file changed

Lines changed: 12 additions & 16 deletions

File tree

src/disk.c

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -277,14 +277,12 @@ int disk_part_read(int drv, int part, uint64_t off, uint64_t sz, uint8_t *buf)
277277
{
278278
struct disk_partition *p = open_part(drv, part);
279279
uint64_t start;
280-
int len;
281280
int ret;
282281
if (p == NULL) {
283282
return -1;
284283
}
285284
if (sz > DISK_IO_MAX_SIZE)
286285
sz = DISK_IO_MAX_SIZE;
287-
len = (int)sz;
288286
start = p->start + off;
289287
/* overflow */
290288
if (start < p->start) {
@@ -294,16 +292,16 @@ int disk_part_read(int drv, int part, uint64_t off, uint64_t sz, uint8_t *buf)
294292
if (start > p->end) {
295293
return -1;
296294
}
297-
if ((p->end - start + 1) < sz) {
298-
len = (uint32_t)(p->end - start + 1);
299-
}
300-
ret = disk_read(drv, start, len, buf);
295+
if ((p->end - start + 1) < sz)
296+
sz = p->end - start + 1;
297+
ret = disk_read(drv, start, (uint32_t)sz, buf);
301298
#ifdef DEBUG_DISK
302299
wolfBoot_printf("disk_part_read: drv: %d, part: %d, off: %llu, sz: %llu, "
303-
"buf: %p, ret %d\r\n", drv, part, p->start + off, len, buf, ret);
300+
"buf: %p, ret %d\r\n", drv, part, p->start + off, (uint32_t)sz, buf,
301+
ret);
304302
#endif
305303
if (ret == 0) {
306-
ret = len; /* success expects to return the number of bytes read */
304+
ret = (int)sz;
307305
}
308306
return ret;
309307
}
@@ -326,14 +324,12 @@ int disk_part_write(int drv, int part, uint64_t off, uint64_t sz, const uint8_t
326324
{
327325
struct disk_partition *p = open_part(drv, part);
328326
uint64_t start;
329-
int len;
330327
int ret;
331328
if (p == NULL) {
332329
return -1;
333330
}
334331
if (sz > DISK_IO_MAX_SIZE)
335332
sz = DISK_IO_MAX_SIZE;
336-
len = (int)sz;
337333
start = p->start + off;
338334
/* overflow */
339335
if (start < p->start) {
@@ -342,16 +338,16 @@ int disk_part_write(int drv, int part, uint64_t off, uint64_t sz, const uint8_t
342338
if (start > p->end) {
343339
return -1;
344340
}
345-
if ((p->end - start + 1) < sz) {
346-
len = (uint32_t)(p->end - start + 1);
347-
}
348-
ret = disk_write(drv, start, len, buf);
341+
if ((p->end - start + 1) < sz)
342+
sz = p->end - start + 1;
343+
ret = disk_write(drv, start, (uint32_t)sz, buf);
349344
#ifdef DEBUG_DISK
350345
wolfBoot_printf("disk_part_write: drv: %d, part: %d, off: %llu, sz: %llu, "
351-
"buf: %p, ret %d\r\n", drv, part, p->start + off, sz, buf, ret);
346+
"buf: %p, ret %d\r\n", drv, part, p->start + off, (uint32_t)sz, buf,
347+
ret);
352348
#endif
353349
if (ret == 0) {
354-
ret = len; /* success expects to return the number of bytes written */
350+
ret = (int)sz;
355351
}
356352
return ret;
357353
}

0 commit comments

Comments
 (0)