tolerate precache failures

Author: pranjalisr

src/sw.js

@@ -25,31 +25,18 @@ const otherManifest = [
     url: "/app-shell/index.html",
   },
 ];
-const EXCLUDED_PRECACHE_URLS = new Set([
-  new URL("/icon_512x512.png", self.location).href,
-]);
 
 const allManifestURLs = [...manifest, ...otherManifest].map(
   (entry) => new URL(entry.url, self.location).href,
 );
-const requiredManifestURLs = allManifestURLs.filter(
-  (href) => !EXCLUDED_PRECACHE_URLS.has(href),
-);
-
-const optionalManifestURLs = [...EXCLUDED_PRECACHE_URLS];
 
 self.addEventListener("install", (event) => {
   event.waitUntil(
     (async () => {
       const cache = await caches.open(cacheName);
 
-      // Fail install only if "required" assets fail
-      await cache.addAll(requiredManifestURLs);
-
       // Optional assets: don't fail SW install if these fail
-      await Promise.allSettled(
-        optionalManifestURLs.map((url) => cache.add(url)),
-      );
+      await Promise.allSettled(allManifestURLs.map((url) => cache.add(url)));
     })(),
   );
 });
@@ -60,15 +47,15 @@ self.addEventListener("activate", (event) => {
       // clean up those who are not listed in manifestURLs
       const keys = await cache.keys();
       for (const request of keys) {
-        if (!requiredManifestURLs.includes(request.url)) {
+        if (!allManifestURLs.includes(request.url)) {
           await cache.delete(request);
         }
       }
     })(),
   );
 });
 registerRoute(
-  ({ url }) => requiredManifestURLs.includes(url.href),
+  ({ url }) => allManifestURLs.includes(url.href),
   new NetworkFirst({
     cacheName,
   }),