refactor(ui): remove dead code

Author: ThierryRakotomanana

packages/webpack-cli/src/ui-renderer.ts

@@ -59,12 +59,6 @@ export interface CommandHelpData {
   globalOptions: HelpOption[];
 }
 
-/** Passed to `renderCommandHeader` to describe the running command. */
-export interface CommandMeta {
-  name: string;
-  description: string;
-}
-
 /** One section emitted by `renderInfoOutput`, e.g. "System" or "Binaries". */
 export interface InfoSection {
   title: string;
@@ -139,29 +133,6 @@ export function renderRows(
   }
 }
 
-export function renderCommandHeader(meta: CommandMeta, opts: RenderOptions): void {
-  const { colors, log } = opts;
-  const termWidth = Math.min(opts.columns || MAX_WIDTH, MAX_WIDTH);
-
-  log("");
-  log(`${indent(INDENT)}${colors.bold(colors.cyan("⬡"))} ${colors.bold(`webpack ${meta.name}`)}`);
-  log(divider(termWidth, colors));
-
-  if (meta.description) {
-    const descWidth = termWidth - INDENT * 2;
-    for (const line of wrapValue(meta.description, descWidth)) {
-      log(`${indent(INDENT)}${line}`);
-    }
-    log("");
-  }
-}
-
-export function renderCommandFooter(opts: RenderOptions): void {
-  const termWidth = Math.min(opts.columns, MAX_WIDTH);
-  opts.log(divider(termWidth, opts.colors));
-  opts.log("");
-}
-
 function _renderHelpOptions(
   options: HelpOption[],
   colors: Colors,
@@ -286,11 +257,6 @@ export function renderWarning(message: string, opts: RenderOptions): void {
   log(`${indent(INDENT)}${colors.yellow("⚠")} ${message}`);
 }
 
-export function renderInfo(message: string, opts: RenderOptions): void {
-  const { colors, log } = opts;
-  log(`${indent(INDENT)}${colors.cyan("ℹ")} ${message}`);
-}
-
 export function parseEnvinfoSections(raw: string): InfoSection[] {
   const sections: InfoSection[] = [];
   let current: InfoSection | null = null;

test/api/__snapshots__/ui-renderer.test.js.snap.webpack5

@@ -74,23 +74,6 @@ exports[`renderAliasHelp should match snapshot 1`] = `
 ]
 `;
 
-exports[`renderCommandFooter should match snapshot 1`] = `
-[
-  "  ──────────────────────────────────────────────────────────────────────────",
-  "",
-]
-`;
-
-exports[`renderCommandHeader should match snapshot 1`] = `
-[
-  "",
-  "  ⬡ webpack build",
-  "  ──────────────────────────────────────────────────────────────────────────",
-  "  Compiling.",
-  "",
-]
-`;
-
 exports[`renderCommandHelp should match full output snapshot for build command 1`] = `
 [
   "",
@@ -182,12 +165,6 @@ exports[`renderFooter should match snapshot (verbose) 1`] = `
 ]
 `;
 
-exports[`renderInfo should match snapshot 1`] = `
-[
-  "  ℹ just so you know",
-]
-`;
-
 exports[`renderInfoOutput should match full output snapshot 1`] = `
 [
   "",

test/api/ui-renderer.test.js

@@ -3,12 +3,9 @@ const {
   MAX_WIDTH,
   parseEnvinfoSections,
   renderAliasHelp,
-  renderCommandFooter,
-  renderCommandHeader,
   renderCommandHelp,
   renderError,
   renderFooter,
-  renderInfo,
   renderInfoOutput,
   renderOptionHelp,
   renderSuccess,
@@ -292,84 +289,6 @@ describe("renderCommandHelp", () => {
   });
 });
 
-describe("renderCommandHeader", () => {
-  it("should render 'webpack <name>' in the header", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandHeader({ name: "build", description: "Compiling." }, opts);
-    expect(getOutput(captured)).toContain("webpack build");
-  });
-
-  it("should render the description", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandHeader({ name: "build", description: "Compiling." }, opts);
-    expect(getOutput(captured)).toContain("Compiling.");
-  });
-
-  it("should render a divider", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandHeader({ name: "build", description: "Compiling." }, opts);
-    expect(captured.some((l) => /─{10,}/.test(l))).toBe(true);
-  });
-
-  it("should include the ⬡ icon", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandHeader({ name: "build", description: "Compiling." }, opts);
-    expect(getOutput(captured)).toContain("⬡");
-  });
-
-  it("should omit description block when empty", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandHeader({ name: "build", description: "" }, opts);
-    const nonEmpty = captured.filter((l) => l.trim().length > 0);
-    expect(nonEmpty).toHaveLength(2); // icon+title + divider
-  });
-
-  it("should cap divider at MAX_WIDTH on wide terminals", () => {
-    const { captured, opts } = makeOpts(300);
-    renderCommandHeader({ name: "build", description: "Building." }, opts);
-    const div = captured.find((l) => /─{10,}/.test(l));
-    expect(stripAnsi(div).length).toBeLessThanOrEqual(INDENT + MAX_WIDTH);
-  });
-
-  it("should match snapshot", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandHeader({ name: "build", description: "Compiling." }, opts);
-    expect(captured).toMatchSnapshot();
-  });
-});
-
-describe("renderCommandFooter", () => {
-  it("should render a divider", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandFooter(opts);
-    expect(captured.some((l) => /─{10,}/.test(l))).toBe(true);
-  });
-
-  it("should end with a blank line", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandFooter(opts);
-    expect(captured[captured.length - 1]).toBe("");
-  });
-
-  it("header and footer dividers should be the same length", () => {
-    const hCapture = makeOpts(80);
-    renderCommandHeader({ name: "build", description: "" }, hCapture.opts);
-    const hDiv = hCapture.captured.find((l) => /─{10,}/.test(l));
-
-    const fCapture = makeOpts(80);
-    renderCommandFooter(fCapture.opts);
-    const fDiv = fCapture.captured.find((l) => /─{10,}/.test(l));
-
-    expect(stripAnsi(hDiv)).toHaveLength(stripAnsi(fDiv).length);
-  });
-
-  it("should match snapshot", () => {
-    const { captured, opts } = makeOpts();
-    renderCommandFooter(opts);
-    expect(captured).toMatchSnapshot();
-  });
-});
-
 describe("renderOptionHelp", () => {
   it("should render option name in header", () => {
     const { captured, opts } = makeOpts();
@@ -573,21 +492,6 @@ describe("renderWarning", () => {
   });
 });
 
-describe("renderInfo", () => {
-  it("outputs message with ℹ", () => {
-    const { captured, opts } = makeOpts();
-    renderInfo("just so you know", opts);
-    expect(getOutput(captured)).toContain("ℹ");
-    expect(getOutput(captured)).toContain("just so you know");
-  });
-
-  it("should match snapshot", () => {
-    const { captured, opts } = makeOpts();
-    renderInfo("just so you know", opts);
-    expect(captured).toMatchSnapshot();
-  });
-});
-
 describe("parseEnvinfoSections", () => {
   it("returns one section per heading", () => {
     const sections = parseEnvinfoSections(ENVINFO_FIXTURE);