Skip to content

Commit fb082ac

Browse files
committed
Apply suggestions from code review
1 parent 8918d29 commit fb082ac

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

libsql-server/src/main.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ struct Cli {
298298
long,
299299
env = "LIBSQL_SYNC_CONCCURENCY",
300300
requires = "sync_from_storage",
301-
default_value = "8",
301+
default_value = "8"
302302
)]
303303
sync_conccurency: usize,
304304
}

libsql-wal/src/checkpointer.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ where
158158
self.errors = 0;
159159
}
160160
}
161-
Some(Err(e)) => panic!("checkoint task panicked: {e}"),
161+
Some(Err(e)) => panic!("checkpoint task panicked: {e}"),
162162
None => unreachable!("got None, but join set is not empty")
163163
}
164164
}

libsql-wal/src/registry.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -543,7 +543,6 @@ where
543543
Some(Ok(mut frame)) => {
544544
if stream.peek().await.is_none() {
545545
drop(stream);
546-
frame.header_mut().frame_no();
547546
frame.header_mut().set_size_after(seen.len() as _);
548547
injector.insert_frame(frame).await?;
549548
break;

libsql-wal/src/segment/sealed.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ where
110110
while let Some((page_no_bytes, offset)) = pages.next() {
111111
let (mut b, ret) = self.read_frame_offset_async(offset as _, buffer).await;
112112
ret?;
113-
// transaction boundaries in a segment are completely erased. The responsibility in on
114-
// the user of the segment to place the transaction boundary such that all frames from
113+
// transaction boundaries in a segment are completely erased. The responsibility is on
114+
// the consumer of the segment to place the transaction boundary such that all frames from
115115
// the segment are applied within the same transaction.
116116
b.get_mut().header_mut().set_size_after(0);
117117
hasher.update(&b.get_ref().as_bytes());

0 commit comments

Comments
 (0)