Skip to content

Commit 405c710

Browse files
committed
refine comment
1 parent ac60c10 commit 405c710

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213390,7 +213390,8 @@ int diskAnnDelete(
213390213390

213391213391
rc = blobSpotCreate(pIndex, &pNodeBlob, nodeRowid, pIndex->nBlockSize, DISKANN_BLOB_WRITABLE);
213392213392
if( rc == DISKANN_ROW_NOT_FOUND ){
213393-
// we omit rows with NULL values so it can be the case that there is nothing to delete in the index while row exists in the base table
213393+
// as we omit rows with NULL values during insert, it can be the case that there is nothing to delete in the index, while row exists in the base table
213394+
// so, we must simply silently stop delete process as there is nothing to delete from index
213394213395
rc = SQLITE_OK;
213395213396
goto out;
213396213397
}else if( rc != SQLITE_OK ){

libsql-ffi/bundled/src/sqlite3.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213390,7 +213390,8 @@ int diskAnnDelete(
213390213390

213391213391
rc = blobSpotCreate(pIndex, &pNodeBlob, nodeRowid, pIndex->nBlockSize, DISKANN_BLOB_WRITABLE);
213392213392
if( rc == DISKANN_ROW_NOT_FOUND ){
213393-
// we omit rows with NULL values so it can be the case that there is nothing to delete in the index while row exists in the base table
213393+
// as we omit rows with NULL values during insert, it can be the case that there is nothing to delete in the index, while row exists in the base table
213394+
// so, we must simply silently stop delete process as there is nothing to delete from index
213394213395
rc = SQLITE_OK;
213395213396
goto out;
213396213397
}else if( rc != SQLITE_OK ){

libsql-sqlite3/src/vectordiskann.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1634,7 +1634,8 @@ int diskAnnDelete(
16341634

16351635
rc = blobSpotCreate(pIndex, &pNodeBlob, nodeRowid, pIndex->nBlockSize, DISKANN_BLOB_WRITABLE);
16361636
if( rc == DISKANN_ROW_NOT_FOUND ){
1637-
// we omit rows with NULL values so it can be the case that there is nothing to delete in the index while row exists in the base table
1637+
// as we omit rows with NULL values during insert, it can be the case that there is nothing to delete in the index, while row exists in the base table
1638+
// so, we must simply silently stop delete process as there is nothing to delete from index
16381639
rc = SQLITE_OK;
16391640
goto out;
16401641
}else if( rc != SQLITE_OK ){

0 commit comments

Comments
 (0)